Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 346113003: Move ENABLE_MEDIA_CAPTURE to a runtime flag (Closed)

Created:
6 years, 6 months ago by lgombos
Modified:
6 years, 5 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Move ENABLE_MEDIA_CAPTURE to a runtime flag The effort needs 3 steps: 1. Create the runtime flag interface in blink; 2. Enable the flag for Android from chromium even it does not do anything in blink; 3. Replace compile time guard with runtime flag in blink and remove the build time flag This is the second step. BUG=388093 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/child/runtime_features.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lgombos
PTAL. Thanks !
6 years, 6 months ago (2014-06-25 02:41:13 UTC) #1
Avi (use Gerrit)
lgtm stamp
6 years, 6 months ago (2014-06-25 14:34:53 UTC) #2
lgombos
The CQ bit was checked by l.gombos@samsung.com
6 years, 5 months ago (2014-06-26 22:08:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/346113003/1
6 years, 5 months ago (2014-06-26 22:09:34 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 00:11:56 UTC) #5
Message was sent while issue was closed.
Change committed as 280180

Powered by Google App Engine
This is Rietveld 408576698