Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 346113002: Revert of Add chrome/renderer to the GN build. (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
jamesr, brettw
CC:
avayvod+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, hclam+watch_chromium.org, hguihot+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, mikhal+watch_chromium.org, miu+watch_chromium.org, pwestin+watch_google.com, tfarina
Project:
chromium
Visibility:
Public.

Description

Revert of Add chrome/renderer to the GN build. (https://codereview.chromium.org/343233004/) Reason for revert: I believe this broke the GN canary on the Blink waterfall: http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN/builds/1691 Original issue's description: > Add chrome/renderer to the GN build. > > Adds some dependencies, also enables compiling of chrome/common. > > Adds disable_nacl and safe_browsing feature flags. > > R=jamesr@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278916 TBR=jamesr@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -475 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M apps/common/api/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M apps/common/api/api.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M build/config/features.gni View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/chrome_renderer.gypi View 7 chunks +280 lines, -283 lines 0 comments Download
M chrome/common/BUILD.gn View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +0 lines, -133 lines 0 comments Download
M components/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M media/cast/cast.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D media/cast/logging/proto/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
Created Revert of Add chrome/renderer to the GN build.
6 years, 6 months ago (2014-06-21 14:06:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/346113002/1
6 years, 6 months ago (2014-06-21 14:07:32 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-21 14:08:28 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-21 14:08:29 UTC) #4
Failed to apply patch for chrome/chrome_renderer.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/chrome_renderer.gypi
  Hunk #4 FAILED at 292.
  Hunk #6 FAILED at 347.
  2 out of 7 hunks FAILED -- saving rejects to file
chrome/chrome_renderer.gypi.rej

Patch:       chrome/chrome_renderer.gypi
Index: chrome/chrome_renderer.gypi
diff --git a/chrome/chrome_renderer.gypi b/chrome/chrome_renderer.gypi
index
4d402dddeaa4501614843b9521c053e99a4546a7..b3fbf86253d4024d415d6186606e69817ad65c2b
100644
--- a/chrome/chrome_renderer.gypi
+++ b/chrome/chrome_renderer.gypi
@@ -3,260 +3,6 @@
 # found in the LICENSE file.
 
 {
-  'variables': {
-    'chrome_renderer_sources': [
-      'renderer/benchmarking_extension.cc',
-      'renderer/benchmarking_extension.h',
-      'renderer/extensions/app_bindings.cc',
-      'renderer/extensions/app_bindings.h',
-      'renderer/extensions/automation_internal_custom_bindings.cc',
-      'renderer/extensions/automation_internal_custom_bindings.h',
-      'renderer/extensions/chrome_extension_helper.cc',
-      'renderer/extensions/chrome_extension_helper.h',
-      'renderer/extensions/chrome_extensions_dispatcher_delegate.cc',
-      'renderer/extensions/chrome_extensions_dispatcher_delegate.h',
-      'renderer/extensions/chrome_extensions_renderer_client.cc',
-      'renderer/extensions/chrome_extensions_renderer_client.h',
-      'renderer/extensions/chrome_v8_context.cc',
-      'renderer/extensions/chrome_v8_context.h',
-      'renderer/extensions/enterprise_platform_keys_natives.cc',
-      'renderer/extensions/enterprise_platform_keys_natives.h',
-      'renderer/extensions/extension_frame_helper.cc',
-      'renderer/extensions/extension_frame_helper.h',
-      'renderer/extensions/extension_localization_peer.cc',
-      'renderer/extensions/extension_localization_peer.h',
-      'renderer/extensions/file_browser_private_custom_bindings.cc',
-      'renderer/extensions/file_browser_private_custom_bindings.h',
-      'renderer/extensions/media_galleries_custom_bindings.cc',
-      'renderer/extensions/media_galleries_custom_bindings.h',
-      'renderer/extensions/notifications_native_handler.cc',
-      'renderer/extensions/notifications_native_handler.h',
-      'renderer/extensions/page_capture_custom_bindings.cc',
-      'renderer/extensions/page_capture_custom_bindings.h',
-      'renderer/extensions/renderer_permissions_policy_delegate.cc',
-      'renderer/extensions/renderer_permissions_policy_delegate.h',
-      'renderer/extensions/resource_request_policy.cc',
-      'renderer/extensions/resource_request_policy.h',
-      'renderer/extensions/sync_file_system_custom_bindings.cc',
-      'renderer/extensions/sync_file_system_custom_bindings.h',
-      'renderer/extensions/tab_finder.cc',
-      'renderer/extensions/tab_finder.h',
-      'renderer/extensions/webstore_bindings.cc',
-      'renderer/extensions/webstore_bindings.h',
-      'renderer/isolated_world_ids.h',
-      'renderer/loadtimes_extension_bindings.cc',
-      'renderer/loadtimes_extension_bindings.h',
-      'renderer/media/cast_rtp_stream.cc',
-      'renderer/media/cast_rtp_stream.h',
-      'renderer/media/cast_ipc_dispatcher.cc',
-      'renderer/media/cast_ipc_dispatcher.h',
-      'renderer/media/cast_session.cc',
-      'renderer/media/cast_session.h',
-      'renderer/media/cast_session_delegate.cc',
-      'renderer/media/cast_session_delegate.h',
-      'renderer/media/cast_threads.cc',
-      'renderer/media/cast_threads.h',
-      'renderer/media/cast_transport_sender_ipc.cc',
-      'renderer/media/cast_transport_sender_ipc.h',
-      'renderer/media/cast_udp_transport.cc',
-      'renderer/media/cast_udp_transport.h',
-      'renderer/media/chrome_key_systems.cc',
-      'renderer/media/chrome_key_systems.h',
-      'renderer/net/net_error_helper.cc',
-      'renderer/net/net_error_helper.h',
-      'renderer/net/net_error_helper_core.cc',
-      'renderer/net/net_error_helper_core.h',
-      'renderer/net/net_error_page_controller.cc',
-      'renderer/net/net_error_page_controller.h',
-      'renderer/net/predictor_queue.cc',
-      'renderer/net/predictor_queue.h',
-      'renderer/net/prescient_networking_dispatcher.cc',
-      'renderer/net/prescient_networking_dispatcher.h',
-      'renderer/net/renderer_net_predictor.cc',
-      'renderer/net/renderer_net_predictor.h',
-      'renderer/net_benchmarking_extension.cc',
-      'renderer/net_benchmarking_extension.h',
-      'renderer/playback_extension.cc',
-      'renderer/playback_extension.h',
-      'renderer/principals_extension_bindings.cc',
-      'renderer/principals_extension_bindings.h',
-      'renderer/resources/extensions/app_custom_bindings.js',
-      'renderer/resources/extensions/app_window_custom_bindings.js',
-      'renderer/resources/extensions/automation_custom_bindings.js',
-      'renderer/resources/extensions/browser_action_custom_bindings.js',
-      'renderer/resources/extensions/chrome_direct_setting.js',
-      'renderer/resources/extensions/chrome_setting.js',
-      'renderer/resources/extensions/content_setting.js',
-      'renderer/resources/extensions/declarative_content_custom_bindings.js',
-     
'renderer/resources/extensions/declarative_webrequest_custom_bindings.js',
-     
'renderer/resources/extensions/enterprise_platform_keys_custom_bindings.js',
-      'renderer/resources/extensions/feedback_private_custom_bindings.js',
-      'renderer/resources/extensions/file_browser_handler_custom_bindings.js',
-      'renderer/resources/extensions/file_browser_private_custom_bindings.js',
-      'renderer/resources/extensions/file_system_custom_bindings.js',
-      'renderer/resources/extensions/file_system_provider_custom_bindings.js',
-      'renderer/resources/extensions/gcm_custom_bindings.js',
-      'renderer/resources/extensions/identity_custom_bindings.js',
-      'renderer/resources/extensions/image_writer_private_custom_bindings.js',
-      'renderer/resources/extensions/input.ime_custom_bindings.js',
-      'renderer/resources/extensions/notifications_custom_bindings.js',
-      'renderer/resources/extensions/omnibox_custom_bindings.js',
-      'renderer/resources/extensions/page_action_custom_bindings.js',
-      'renderer/resources/extensions/page_actions_custom_bindings.js',
-      'renderer/resources/extensions/page_capture_custom_bindings.js',
-      'renderer/resources/extensions/system_indicator_custom_bindings.js',
-      'renderer/resources/extensions/tts_custom_bindings.js',
-      'renderer/resources/extensions/tts_engine_custom_bindings.js',
-      'renderer/resources/extensions/web_request_custom_bindings.js',
-      'renderer/resources/extensions/web_view.js',
-      'renderer/resources/extensions/web_view_events.js',
-      'renderer/resources/extensions/web_view_experimental.js',
-      'renderer/resources/extensions/webview_custom_bindings.js',
-      'renderer/chrome_content_renderer_client.cc',
-      'renderer/chrome_content_renderer_client.h',
-      'renderer/chrome_render_frame_observer.cc',
-      'renderer/chrome_render_frame_observer.h',
-      'renderer/chrome_render_process_observer.cc',
-      'renderer/chrome_render_process_observer.h',
-      'renderer/chrome_render_view_observer.cc',
-      'renderer/chrome_render_view_observer.h',
-      'renderer/content_settings_observer.cc',
-      'renderer/content_settings_observer.h',
-      'renderer/custom_menu_commands.h',
-      'renderer/external_extension.cc',
-      'renderer/external_extension.h',
-      'renderer/page_load_histograms.cc',
-      'renderer/page_load_histograms.h',
-      'renderer/plugins/chrome_plugin_placeholder.cc',
-      'renderer/plugins/chrome_plugin_placeholder.h',
-      'renderer/plugins/plugin_uma.cc',
-      'renderer/plugins/plugin_uma.h',
-      'renderer/prefetch_helper.cc',
-      'renderer/prefetch_helper.h',
-      'renderer/prerender/prerender_dispatcher.cc',
-      'renderer/prerender/prerender_dispatcher.h',
-      'renderer/prerender/prerender_extra_data.cc',
-      'renderer/prerender/prerender_extra_data.h',
-      'renderer/prerender/prerender_helper.cc',
-      'renderer/prerender/prerender_helper.h',
-      'renderer/prerender/prerenderer_client.cc',
-      'renderer/prerender/prerenderer_client.h',
-      'renderer/searchbox/search_bouncer.cc',
-      'renderer/searchbox/search_bouncer.h',
-      'renderer/searchbox/searchbox.cc',
-      'renderer/searchbox/searchbox.h',
-      'renderer/searchbox/searchbox_extension.cc',
-      'renderer/searchbox/searchbox_extension.h',
-      'renderer/security_filter_peer.cc',
-      'renderer/security_filter_peer.h',
-      'renderer/tts_dispatcher.cc',
-      'renderer/tts_dispatcher.h',
-      'renderer/translate/translate_helper.cc',
-      'renderer/translate/translate_helper.h',
-      'renderer/web_apps.cc',
-      'renderer/web_apps.h',
-      'renderer/webview_color_overlay.cc',
-      'renderer/webview_color_overlay.h',
-      'renderer/worker_permission_client_proxy.cc',
-      'renderer/worker_permission_client_proxy.h',
-    ],
-    'chrome_renderer_webrtc_sources': [
-      'renderer/extensions/cast_streaming_native_handler.cc',
-      'renderer/extensions/cast_streaming_native_handler.h',
-      'renderer/media/chrome_webrtc_log_message_delegate.cc',
-      'renderer/media/chrome_webrtc_log_message_delegate.h',
-      'renderer/media/webrtc_logging_message_filter.cc',
-      'renderer/media/webrtc_logging_message_filter.h',
-    ],
-    'chrome_renderer_extensions_sources': [
-      'renderer/extensions/chrome_extensions_render_frame_observer.cc',
-      'renderer/extensions/chrome_extensions_render_frame_observer.h',
-    ],
-    'chrome_renderer_non_android_sources': [
-      'renderer/extensions/app_window_custom_bindings.cc',
-      'renderer/extensions/app_window_custom_bindings.h',
-      'renderer/extensions/chrome_v8_extension_handler.cc',
-…
(message too large)

Powered by Google App Engine
This is Rietveld 408576698