try to reuse ffmpeg config for linux on other *nix

Adding a new os_config variable so that non-linux OS's like FreeBSD, OpenBSD, and Solaris can reuse the linux config.  I also added a linker flag so the system libvpx can be pulled in.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63146

[ruben, 2010-09-28 08:02:53]

Hey, small patch to reuse linux config, plus added a -L for system libvpx, as it
couldn't find libvpx.so otherwise.

[scherkus (not reviewing), 2010-10-14 18:44:50]

sorry for the delay!  just found this now :(

patch LGTM although I will warn you use_system_ffmpeg/use_system_vpx are likely
to break (we don't guarantee the ABI won't change)

[ruben, 2010-10-14 18:47:36]

On 2010/10/14 18:44:50, scherkus wrote:
> sorry for the delay!  just found this now :(
> 
> patch LGTM although I will warn you use_system_ffmpeg/use_system_vpx are
likely
> to break (we don't guarantee the ABI won't change)
No problem, use_system_vpx has been working for now and I don't use
use_system_ffmpeg anyway.  You'll have to commit as I'm not a committer.

[scherkus (not reviewing), 2010-10-14 19:03:42]

http://codereview.chromium.org/3461024/diff/4001/5001
File ffmpeg.gyp (right):

http://codereview.chromium.org/3461024/diff/4001/5001#newcode432
ffmpeg.gyp:432: '-L/usr/local/lib',
shouldn't this already be in the path?

use_system_vpx just uses -lvpx and assumes that its in your default path

[ruben, 2010-10-14 19:11:34]

http://codereview.chromium.org/3461024/diff/4001/5001
File ffmpeg.gyp (right):

http://codereview.chromium.org/3461024/diff/4001/5001#newcode432
ffmpeg.gyp:432: '-L/usr/local/lib',
On 2010/10/14 19:03:42, scherkus wrote:
> shouldn't this already be in the path?
> 
> use_system_vpx just uses -lvpx and assumes that its in your default path
Yes, I was surprised it wasn't also, but how would that path get pulled in for
ffmpeg exactly?  ffmpeg.gyp doesn't call any of the pkg-config targets from
build/linux/system.gyp, nor does it invoke pkg-config itself for the flags for
libvpx.  On FreeBSD, that caused a linking failure: has the use_system_vpx flag
been tested on linux?

[scherkus (not reviewing), 2010-10-14 19:40:48]

+fta

fta: are you using use_system_vpx at all?  do you know if we can use pkg-config
with libvpx?

http://codereview.chromium.org/3461024/diff/4001/5001
File ffmpeg.gyp (right):

http://codereview.chromium.org/3461024/diff/4001/5001#newcode432
ffmpeg.gyp:432: '-L/usr/local/lib',
On 2010/10/14 19:11:35, ruben wrote:
> On 2010/10/14 19:03:42, scherkus wrote:
> > shouldn't this already be in the path?
> > 
> > use_system_vpx just uses -lvpx and assumes that its in your default path
> Yes, I was surprised it wasn't also, but how would that path get pulled in for
> ffmpeg exactly?  ffmpeg.gyp doesn't call any of the pkg-config targets from
> build/linux/system.gyp, nor does it invoke pkg-config itself for the flags for
> libvpx.  On FreeBSD, that caused a linking failure: has the use_system_vpx
flag
> been tested on linux?

I think when libvpx was first released they didn't offer a pkg-config (see
comment at top for use_system_vpx)

I'd fine using a pkg-config line similar to use_system_ffmpeg for CFLAGS

[fbarchard, 2010-10-14 19:57:17]

Note that the libvpx checked in likely better than the one a distro comes
with
1. its built with intel c, gain 11% perf
2. we recently fixed lucid threading issues.  almost doubled performance.
We're still considering going to ffmpeg-mt's version of vp8, if it's
threading version proves to be a win.

I'm not in favor of other linux config headers.  The current ones have been
generated to work with freebsd and gentoo.  If theres another system they
dont work on, its best to report the issue and we fix it.  use_system_ffmpeg
has been problematic to support, as ffmpeg changes api's frequently.  I
expect libvpx to change quickly for awhile too.

On Thu, Oct 14, 2010 at 12:40 PM, <scherkus@chromium.org> wrote:

> +fta
>
> fta: are you using use_system_vpx at all?  do you know if we can use
> pkg-config
> with libvpx?
>
>
>
>
>
> http://codereview.chromium.org/3461024/diff/4001/5001
> File ffmpeg.gyp (right):
>
> http://codereview.chromium.org/3461024/diff/4001/5001#newcode432
> ffmpeg.gyp:432: '-L/usr/local/lib',
> On 2010/10/14 19:11:35, ruben wrote:
>
>> On 2010/10/14 19:03:42, scherkus wrote:
>> > shouldn't this already be in the path?
>> >
>> > use_system_vpx just uses -lvpx and assumes that its in your default
>>
> path
>
>> Yes, I was surprised it wasn't also, but how would that path get
>>
> pulled in for
>
>> ffmpeg exactly?  ffmpeg.gyp doesn't call any of the pkg-config targets
>>
> from
>
>> build/linux/system.gyp, nor does it invoke pkg-config itself for the
>>
> flags for
>
>> libvpx.  On FreeBSD, that caused a linking failure: has the
>>
> use_system_vpx flag
>
>> been tested on linux?
>>
>
> I think when libvpx was first released they didn't offer a pkg-config
> (see comment at top for use_system_vpx)
>
> I'd fine using a pkg-config line similar to use_system_ffmpeg for CFLAGS
>
>
> http://codereview.chromium.org/3461024/show
>

[ruben, 2010-10-16 21:46:35]

> On Thu, Oct 14, 2010 at 12:40 PM, <mailto:scherkus@chromium.org> wrote:
> > fta: are you using use_system_vpx at all?  do you know if we can use
> > pkg-config
> > with libvpx?
> > I think when libvpx was first released they didn't offer a pkg-config
> > (see comment at top for use_system_vpx)
> >
> > I'd fine using a pkg-config line similar to use_system_ffmpeg for CFLAGS
FreeBSD still doesn't have a libvpx.pc for its libvpx package, so pkg-config
won't work.

On 2010/10/14 19:57:17, fbarchard wrote:
> Note that the libvpx checked in likely better than the one a distro comes
> with
> 1. its built with intel c, gain 11% perf
> 2. we recently fixed lucid threading issues.  almost doubled performance.
> We're still considering going to ffmpeg-mt's version of vp8, if it's
> threading version proves to be a win.
> 
> I'm not in favor of other linux config headers.  The current ones have been
> generated to work with freebsd and gentoo.  If theres another system they
> dont work on, its best to report the issue and we fix it.  use_system_ffmpeg
> has been problematic to support, as ffmpeg changes api's frequently.  I
> expect libvpx to change quickly for awhile too.
Note that this patch has nothing to do with "other linux config headers."  All
it does is allow non-mac/win OS's to reuse the config headers that you have
generated for FreeBSD/gentoo.  Further, it adds a linker flag so that the
use_system_vpx flag can actually be used, though of course it won't be expected
to always work because of libvpx changes, as you said.

[fbarchard, 2010-10-18 22:17:36]

On Sat, Oct 16, 2010 at 2:46 PM, <chromium@hybridsource.org> wrote:

> On Thu, Oct 14, 2010 at 12:40 PM, <mailto:scherkus@chromium.org> wrote:
>> > fta: are you using use_system_vpx at all?  do you know if we can use
>> > pkg-config
>> > with libvpx?
>> > I think when libvpx was first released they didn't offer a pkg-config
>> > (see comment at top for use_system_vpx)
>> >
>> > I'd fine using a pkg-config line similar to use_system_ffmpeg for CFLAGS
>>
> FreeBSD still doesn't have a libvpx.pc for its libvpx package, so
> pkg-config
> won't work.


I've reported that to WebM
http://code.google.com/p/webm/issues/detail?id=200

[ruben, 2010-10-18 22:21:28]

On 2010/10/18 22:17:36, fbarchard wrote:
> > FreeBSD still doesn't have a libvpx.pc for its libvpx package, so
> > pkg-config
> > won't work. 
> I've reported that to WebM
> http://code.google.com/p/webm/issues/detail?id=200
I don't think this is a FreeBSD issue, linux distros probably don't have one
other, unless they're writing it themselves:

http://code.google.com/p/webm/issues/detail?id=67

[scherkus (not reviewing), 2010-10-20 00:09:43]

ok LGTM but I won't guarantee it'll work everywhere :)

[scherkus (not reviewing), 2010-10-20 21:45:13]

Committed as r63146

DEPS roll committed as r63268

[fbarchard, 2010-11-11 20:50:50]

On 2010/10/20 21:45:13, scherkus wrote:
> Committed as r63146
> 
> DEPS roll committed as r63268

This change doesnt seem to work for use_system_vpx.  A build error occurs on
chromoting.

[ruben, 2010-11-11 20:55:44]

On 2010/11/11 20:50:50, fbarchard wrote:
> On 2010/10/20 21:45:13, scherkus wrote:
> > Committed as r63146
> > 
> > DEPS roll committed as r63268
> 
> This change doesnt seem to work for use_system_vpx.  A build error occurs on
> chromoting.
What's the error?  The os_config change shouldn't affect use_system_vpx and
use_system_vpx probably didn't work before without the ldflags addition anyway. 
It's possible the ldflags directory is different for your setup, I simply used
the FreeBSD directory and figured you'd modify it for your setup if necessary.