[XHR] Move bools to end of class declaration for better padding

Source/core/xml/XMLHttpRequest.h

 /*
  *  Copyright (C) 2003, 2006, 2008 Apple Inc. All rights reserved.
  *  Copyright (C) 2005, 2006 Alexey Proskuryakov <ap@nypop.com>
  *  Copyright (C) 2011 Google Inc. All rights reserved.
  *  Copyright (C) 2012 Intel Corporation
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Lesser General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
@@ skipping 84 matching lines @@
     virtual void resume() OVERRIDE;
     virtual void stop() OVERRIDE;
 
     virtual const AtomicString& interfaceName() const OVERRIDE;
     virtual ExecutionContext* executionContext() const OVERRIDE;
 
     const KURL& url() const { return m_url; }
     String statusText() const;
     int status() const;
     State readyState() const;
-    bool withCredentials() const { return m_includeCredentials; }
+    bool withCredentials() const { return getFlag(IsWithCredentials); }
     void setWithCredentials(bool, ExceptionState&);
     void open(const AtomicString& method, const KURL&, ExceptionState&);
     void open(const AtomicString& method, const KURL&, bool async, ExceptionState&);
     void open(const AtomicString& method, const KURL&, bool async, const String& user, ExceptionState&);
     void open(const AtomicString& method, const KURL&, bool async, const String& user, const String& password, ExceptionState&);
     void send(ExceptionState&);
     void send(Document*, ExceptionState&);
     void send(const String&, ExceptionState&);
     void send(Blob*, ExceptionState&);
     void send(DOMFormData*, ExceptionState&);
@@ skipping 36 matching lines @@
     DEFINE_ATTRIBUTE_EVENT_LISTENER(readystatechange);
 
     virtual void trace(Visitor*) OVERRIDE;
 
 private:
     XMLHttpRequest(ExecutionContext*, PassRefPtr<SecurityOrigin>);
 
     Document* document() const;
     SecurityOrigin* securityOrigin() const;
 
+    enum XMLHttpRequestFlags {
+        IsAsync = 1,
+        IsWithCredentials = 1 << 1,

[Inactive, 2014/06/21 00:40:41]

Maybe just "WithCredentials"?

[maheshkk, 2014/06/23 18:32:16]

Done.

+        IsDocumentCreated = 1 << 2,
+        HasError = 1 << 3,
+        IsUploadEventsAllowed = 1 << 4,
+        IsUploadComplete = 1 << 5,
+        IsSameOriginRequest = 1 << 6
+        // 1 bit remainig. If added more then increase the size of m_xhrFlags.

[Inactive, 2014/06/21 00:40:41]

typo: "remaining"

[maheshkk, 2014/06/23 18:32:16]

Done.

+    };
+
+    inline bool getFlag (XMLHttpRequestFlags mask) const { return m_xhrFlags & mask; }

[Inactive, 2014/06/21 00:40:41]

nit: extra space after getFlag. "inline" is redundant here and for other inlined
methods below.

[maheshkk, 2014/06/23 18:32:16]

Done.

+    inline void setFlag(XMLHttpRequestFlags mask) { m_xhrFlags |= mask; }
+    inline void setFlag(bool f, XMLHttpRequestFlags mask) { m_xhrFlags = (m_xhrFlags & ~mask) | (-(int8_t)f & mask); }
+    inline void clearFlag(XMLHttpRequestFlags mask) { m_xhrFlags &= ~mask; }
+
     virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent) OVERRIDE;
     virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&) OVERRIDE;
     virtual void didReceiveData(const char* data, int dataLength) OVERRIDE;
     // When responseType is set to "blob", didDownloadData() is called instead
     // of didReceiveData().
     virtual void didDownloadData(int dataLength) OVERRIDE;
     virtual void didFinishLoading(unsigned long identifier, double finishTime) OVERRIDE;
     virtual void didFail(const ResourceError&) OVERRIDE;
     virtual void didFailRedirectCheck() OVERRIDE;
 
@@ skipping 38 matching lines @@
     void handleNetworkError();
     // Handles didFail() call triggered by m_loader->cancel().
     void handleDidCancel();
     // Handles didFail() call for timeout.
     void handleDidTimeout();
 
     void handleRequestError(ExceptionCode, const AtomicString&, long long, long long);
 
     OwnPtrWillBeMember<XMLHttpRequestUpload> m_upload;
 
+    u_int8_t m_xhrFlags;

[Inactive, 2014/06/21 00:40:41]

I think we usually use "uint8_t".

[Inactive, 2014/06/21 00:51:20]

Also, considering the small number of flags, I think we could have simply moved
the bool members next to each other like this:
bool m_async : 1;
bool m_includeCredentials : 1;
bool m_createdDocument : 1;
...

This way, there was no need to refactor the code at all.

[maheshkk, 2014/06/21 01:58:41]

As flags are less than 8, I think you are right. I shall try this approach. 

[maheshkk, 2014/06/23 18:32:16]

Done.

     KURL m_url;
     AtomicString m_method;
     HTTPHeaderMap m_requestHeaders;
     AtomicString m_mimeTypeOverride;
-    bool m_async;
-    bool m_includeCredentials;
     unsigned long m_timeoutMilliseconds;
     RefPtrWillBeMember<Blob> m_responseBlob;
     RefPtrWillBeMember<Stream> m_responseStream;
 
     RefPtr<ThreadableLoader> m_loader;
     State m_state;
 
     ResourceResponse m_response;
     String m_responseEncoding;
 
     OwnPtr<TextResourceDecoder> m_decoder;
 
     ScriptString m_responseText;
-    // Used to skip m_responseDocument creation if it's done previously. We need
-    // this separate flag since m_responseDocument can be 0 for some cases.
-    bool m_createdDocument;
     RefPtrWillBeMember<Document> m_responseDocument;
 
     RefPtr<SharedBuffer> m_binaryResponseBuilder;
     long long m_downloadedBlobLength;
 
     RefPtr<ArrayBuffer> m_responseArrayBuffer;
 
-    bool m_error;
-
-    bool m_uploadEventsAllowed;
-    bool m_uploadComplete;
-
-    bool m_sameOriginRequest;
-
     // Used for onprogress tracking
     long long m_receivedLength;
 
     unsigned m_lastSendLineNumber;
     String m_lastSendURL;
     // An exception to throw in synchronous mode. It's set when failure
     // notification is received from m_loader and thrown at the end of send() if
     // any.
     ExceptionCode m_exceptionCode;
 
     XMLHttpRequestProgressEventThrottle m_progressEventThrottle;
 
     // An enum corresponding to the allowed string values for the responseType attribute.
     ResponseTypeCode m_responseTypeCode;
     AsyncMethodRunner<XMLHttpRequest> m_dropProtectionRunner;
     RefPtr<SecurityOrigin> m_securityOrigin;
 };
 
 } // namespace WebCore
 
 #endif // XMLHttpRequest_h