tools/gn/ninja_script_target_writer.cc - Issue 34603009: Improve Windows GN build setup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_script_target_writer.cc

Issue 34603009: Improve Windows GN build setup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_script_target_writer.cc

diff --git a/tools/gn/ninja_script_target_writer.cc b/tools/gn/ninja_script_target_writer.cc

index 4678ba05f43ea039f43686455c45fd6a1b7ec560..b36297667a8a0859663a1d5237e4c191e204108c 100644

--- a/tools/gn/ninja_script_target_writer.cc

+++ b/tools/gn/ninja_script_target_writer.cc

@@ -22,8 +22,6 @@ NinjaScriptTargetWriter::~NinjaScriptTargetWriter() {

}

void NinjaScriptTargetWriter::Run() {

- WriteEnvironment();

FileTemplate args_template(target_->script_values().args());

std::string custom_rule_name = WriteRuleDefinition(args_template);

std::string implicit_deps = GetSourcesImplicitDeps();

« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/ninja_target_writer.h » ('j') | no next file with comments »