Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1800)

Unified Diff: tools/gn/build_settings.cc

Issue 34603009: Improve Windows GN build setup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/build_settings.h ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/build_settings.cc
diff --git a/tools/gn/build_settings.cc b/tools/gn/build_settings.cc
index 2ac7389eea7647a58eaf63ee239f6f0184ed37cc..af81467007c59de5b98665d5cc790baac051067c 100644
--- a/tools/gn/build_settings.cc
+++ b/tools/gn/build_settings.cc
@@ -4,6 +4,7 @@
#include "tools/gn/build_settings.h"
+#include "base/file_util.h"
#include "tools/gn/filesystem_utils.h"
BuildSettings::BuildSettings()
@@ -45,6 +46,9 @@ void BuildSettings::SetSecondarySourcePath(const SourceDir& d) {
void BuildSettings::SetBuildDir(const SourceDir& d) {
build_dir_ = d;
build_to_source_dir_string_ = InvertDir(d);
+
+ DCHECK(!root_path_.empty());
+ file_util::CreateDirectory(build_dir_.Resolve(root_path_));
}
base::FilePath BuildSettings::GetFullPath(const SourceFile& file) const {
« no previous file with comments | « tools/gn/build_settings.h ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698