Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 34603009: Improve Windows GN build setup. (Closed)

Created:
7 years, 2 months ago by brettw
Modified:
7 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Improve Windows GN build setup. Properly setup a new output build directory on Windows (previously you had to manually copy some files into it). It now creates the environment block and the gyp-win-tool. The include and library paths are moved to the command line and removed from the environment which is cleaner and more explicit. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230223

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -52 lines) Patch
M tools/gn/build_settings.h View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/build_settings.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/gn/ninja_binary_target_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/ninja_script_target_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/ninja_target_writer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/ninja_target_writer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/gn/secondary/build/config/win/BUILD.gn View 3 chunks +20 lines, -3 lines 0 comments Download
M tools/gn/secondary/build/toolchain/win/BUILD.gn View 1 2 4 chunks +41 lines, -36 lines 0 comments Download
A tools/gn/secondary/build/toolchain/win/setup_toolchain.py View 1 2 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
7 years, 2 months ago (2013-10-22 20:46:52 UTC) #1
scottmg
this won't work for the x64 toolchain because the PATH has to be different to ...
7 years, 2 months ago (2013-10-22 20:50:20 UTC) #2
brettw
On 2013/10/22 20:50:20, scottmg wrote: > this won't work for the x64 toolchain because the ...
7 years, 2 months ago (2013-10-22 20:51:27 UTC) #3
brettw
Okay, I renamed the environment file to environment.x86. I don't do the x64 one since ...
7 years, 2 months ago (2013-10-22 21:15:43 UTC) #4
scottmg
lgtm
7 years, 2 months ago (2013-10-22 21:20:00 UTC) #5
brettw
7 years, 2 months ago (2013-10-22 22:03:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r230223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698