Issue 34603008: Handlify Map::CopyInstallDescriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 34603008: Handlify Map::CopyInstallDescriptors (Closed)

Created:
7 years, 1 month ago by rafaelw

Modified:
7 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify Map::CopyInstallDescriptors BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17350

Patch Set 4 : cr changes #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -26 lines)			Patch
	M	src/objects.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
	M	src/objects.cc	View	1	2 chunks	+11 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. https://codereview.chromium.org/34603008/diff/1/src/objects.cc File src/objects.cc (left): https://codereview.chromium.org/34603008/diff/1/src/objects.cc#oldcode6854 src/objects.cc:6854: // always insert transitions without ...

7 years, 1 month ago (2013-10-23 08:59:05 UTC) #2

rafaelw

https://codereview.chromium.org/34603008/diff/1/src/objects.cc File src/objects.cc (left): https://codereview.chromium.org/34603008/diff/1/src/objects.cc#oldcode6854 src/objects.cc:6854: // always insert transitions without checking. Woops. Good catch. ...

7 years, 1 month ago (2013-10-23 20:09:51 UTC) #3

rafaelw

7 years, 1 month ago (2013-10-23 22:02:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r17350 (presubmit successful).

Expand Messages | Collapse Messages

Issue 34603008: Handlify Map::CopyInstallDescriptors (Closed)

Description

Patch Set 1 #

Patch Set 2 : cr changes #

Patch Set 3 : sync #

Patch Set 4 : cr changes #

Messages