Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 34603002: Moved app_hardware.html to app_usb.html. Will split out serial port (Closed)

Created:
7 years, 2 months ago by Andy
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, not at google - send to devlin
Visibility:
Public.

Description

Moved app_hardware.html to app_usb.html. Will split out serial port content into a separate article in a follow-on CL. R=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230610

Patch Set 1 #

Patch Set 2 : Re-upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -847 lines) Patch
D chrome/common/extensions/docs/templates/articles/app_hardware.html View 1 chunk +0 lines, -846 lines 0 comments Download
A + chrome/common/extensions/docs/templates/articles/app_usb.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/apps_sidenav.json View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/docs/templates/public/apps/app_hardware.html View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/app_usb.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Andy
7 years, 2 months ago (2013-10-22 07:29:39 UTC) #1
Andy
On 2013/10/22 07:29:39, Andy wrote: I'm not sure why the diffs are showing a "chunk ...
7 years, 2 months ago (2013-10-22 07:38:35 UTC) #2
not at google - send to devlin
Chunk mismatch happens when rietveld upload screws up. you might need to start a new ...
7 years, 2 months ago (2013-10-22 14:27:03 UTC) #3
Andy
On 2013/10/22 14:27:03, kalman wrote: > Chunk mismatch happens when rietveld upload screws up. you ...
7 years, 2 months ago (2013-10-22 22:36:11 UTC) #4
Andy
On 2013/10/22 22:36:11, Andy wrote: > On 2013/10/22 14:27:03, kalman wrote: > > Chunk mismatch ...
7 years, 2 months ago (2013-10-24 02:05:28 UTC) #5
not at google - send to devlin
lgtm
7 years, 2 months ago (2013-10-24 02:45:55 UTC) #6
Andy
7 years, 2 months ago (2013-10-24 03:03:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r230610 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698