Add fillRule option for hit regions on canvas2d.

Add fillRule option for hit regions on canvas2d.

The specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#hitregionoptions

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tRFguWa-oZc

BUG=328961
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177174

[zino, 2014-06-23 10:16:44]

Please take a look.

Thank you.

[Justin Novosad, 2014-06-23 14:44:50]

lgtm with some minor comments.

https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
File LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html (right):

https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:40: // no fill
rule option
I would call thais "default fill rule", rather than  "no fill rule".

https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:43: debug("No
fillRule:");
"Default fill rule (nonzero)"

https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:85:
debug("fillRule = null:");
"fillRule = null, falls back to default (nonzero):"

https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:99:
debug("fillRule = undefined:");
same here

[Rik, 2014-06-23 16:59:35]

lgtm

[zino, 2014-06-23 17:21:41]

Thank you.

https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
File LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html (right):

https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:40: // no fill
rule option
On 2014/06/23 14:44:49, junov wrote:
> I would call thais "default fill rule", rather than  "no fill rule".

Done.

https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:43: debug("No
fillRule:");
On 2014/06/23 14:44:50, junov wrote:
> "Default fill rule (nonzero)"

Done.

https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:85:
debug("fillRule = null:");
On 2014/06/23 14:44:49, junov wrote:
> "fillRule = null, falls back to default (nonzero):"

Done.

https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:99:
debug("fillRule = undefined:");
On 2014/06/23 14:44:50, junov wrote:
> same here

Done.

[Justin Novosad, 2014-06-23 17:26:39]

On 2014/06/23 17:21:41, zino wrote:
> Thank you.
> 
>
https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
> File LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html (right):
> 
>
https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
> LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:40: // no fill
> rule option
> On 2014/06/23 14:44:49, junov wrote:
> > I would call thais "default fill rule", rather than  "no fill rule".
> 
> Done.
> 
>
https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
> LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:43: debug("No
> fillRule:");
> On 2014/06/23 14:44:50, junov wrote:
> > "Default fill rule (nonzero)"
> 
> Done.
> 
>
https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
> LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:85:
> debug("fillRule = null:");
> On 2014/06/23 14:44:49, junov wrote:
> > "fillRule = null, falls back to default (nonzero):"
> 
> Done.
> 
>
https://codereview.chromium.org/346003007/diff/1/LayoutTests/fast/canvas/canv...
> LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html:99:
> debug("fillRule = undefined:");
> On 2014/06/23 14:44:50, junov wrote:
> > same here
> 
> Done.

lgtm

[zino, 2014-06-23 17:31:27]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-06-23 17:31:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/346003007/20001

[commit-bot: I haz the power, 2014-06-23 18:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-23 18:36:09]

Failed to apply patch for Source/core/html/canvas/HitRegion.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/html/canvas/HitRegion.cpp
  Hunk #2 FAILED at 45.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/html/canvas/HitRegion.cpp.rej

Patch:       Source/core/html/canvas/HitRegion.cpp
Index: Source/core/html/canvas/HitRegion.cpp
diff --git a/Source/core/html/canvas/HitRegion.cpp
b/Source/core/html/canvas/HitRegion.cpp
index
d436f45a87cab471ee616f1c80042b24274bbc9a..cb2e827a0ff4962320d01b07e6e329fe44b817a3
100644
--- a/Source/core/html/canvas/HitRegion.cpp
+++ b/Source/core/html/canvas/HitRegion.cpp
@@ -14,6 +14,7 @@ HitRegion::HitRegion(const HitRegionOptions& options)
     : m_id(options.id)
     , m_control(options.control)
     , m_path(options.path)
+    , m_fillRule(options.fillRule)
 {
 }
 
@@ -44,7 +45,7 @@ bool HitRegion::contains(const LayoutPoint& point) const
     if (!m_path.boundingRect().contains(point))
         return false;
 
-    return m_path.contains(point, RULE_NONZERO);
+    return m_path.contains(point, m_fillRule);
 }
 
 void HitRegion::removePixels(const Path& clearArea)

[zino, 2014-06-28 15:20:01]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-06-28 15:21:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/346003007/40001

[commit-bot: I haz the power, 2014-06-28 16:17:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/13353)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14332)

[commit-bot: I haz the power, 2014-06-28 16:25:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-28 16:25:45]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/13373)

[zino, 2014-06-29 08:10:29]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-06-29 08:10:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/346003007/40001

[commit-bot: I haz the power, 2014-06-29 09:13:12]

Change committed as 177174