Issue 345983002: Remove a hard CHECK when allocating instance ID would fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345983002: Remove a hard CHECK when allocating instance ID would fail. (Closed)

Created:
6 years, 6 months ago by lazyboy

Modified:
6 years, 6 months ago

Reviewers:
Fady Samuel

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove a hard CHECK when allocating instance ID would fail. A CHECK here seems too intrusive to me, I've changed it to send error response instead. A compromised renderer should not take down the whole browser process. BUG=364141 Test=None, internal clean up. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278809

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc	View		2 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/345983002/1

6 years, 6 months ago (2014-06-20 16:20:19 UTC) #4

Message was sent while issue was closed.

Change committed as 278809

Expand Messages | Collapse Messages