Source/core/css/CSSCalculationValue.h - Issue 345903005: calc expressions should support time, angle and frequency values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValue.h

Issue 345903005: calc expressions should support time, angle and frequency values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix build warrning. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/css3/calc/calc-with-time-angle-and-frequency-values.html ('K') | « LayoutTests/css3/calc/calc-with-time-angle-and-frequency-values-expected.txt ('k') | Source/core/css/CSSCalculationValue.cpp » ('j') | Source/core/css/CSSCalculationValue.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSCalculationValue.h

diff --git a/Source/core/css/CSSCalculationValue.h b/Source/core/css/CSSCalculationValue.h

index a7678850ffbc1b7cf4191af9c073934fcd4651a3..cd69123b86f7fb01671adda1a2f65ce38d9df588 100644

--- a/Source/core/css/CSSCalculationValue.h

+++ b/Source/core/css/CSSCalculationValue.h

@@ -54,12 +54,17 @@ enum CalcOperator {

CalcDivide = '/'

};

+// The order of this enum should not change since its elements are used as indices

+// in the addSubtractResult matrix.

enum CalculationCategory {

CalcNumber = 0,

CalcLength,

CalcPercent,

CalcPercentNumber,

CalcPercentLength,

+ CalcAngle,

+ CalcTime,

+ CalcFrequency,

CalcOther

};