Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: Source/core/css/CSSPrimitiveValue.h

Issue 345903005: calc expressions should support time, angle and frequency values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSPrimitiveValue.h
diff --git a/Source/core/css/CSSPrimitiveValue.h b/Source/core/css/CSSPrimitiveValue.h
index 76846ab687dc2594d74dc633f276f7ae97ceb738..944c3ee52a4cf628665de8dcc0473eac1f48d634 100644
--- a/Source/core/css/CSSPrimitiveValue.h
+++ b/Source/core/css/CSSPrimitiveValue.h
@@ -285,6 +285,8 @@ public:
return getValue<T>();
if (timeUnit == Milliseconds && m_primitiveUnitType == CSS_S)
return getValue<T>() * 1000;
+ if (m_primitiveUnitType == CSS_CALC)
+ return getValue<T>();
alancutter (OOO until 2018) 2014/07/02 05:56:11 This should be returning a value relative to timeU
Timothy Loh 2014/07/02 07:06:13 Alternatively we can just simplify this function t
ASSERT_NOT_REACHED();
return 0;
}

Powered by Google App Engine
This is Rietveld 408576698