Source/bindings/scripts/v8_interface.py - Issue 345893002: Implement an infrastructure of Blink-in-JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 345893002: Implement an infrastructure of Blink-in-JS Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index abc23b40b0799a94e74ef4cac5b708e45001a601..f392c21b9d94d87dc23e5556ce62b83f3e1cb0f6 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -113,7 +113,7 @@ def generate_interface(interface):

set_wrapper_reference_to_list = [{

'name': argument.name,

# FIXME: properly should be:

- # 'cpp_type': argument.idl_type.cpp_type_args(used_as_argument=True),

+ # 'cpp_type': argument.idl_type.cpp_type_args(used_as_primitive_type=True),

# (if type is non-wrapper type like NodeFilter, normally RefPtr)

# Raw pointers faster though, and NodeFilter hacky anyway.

'cpp_type': argument.idl_type.implemented_as + '*',