Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 345893002: Implement an infrastructure of Blink-in-JS Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/idl.gypi ('k') | Source/bindings/scripts/scripts.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.py
diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py
index 778a87ec79b9d11b1959bd6d4f80820616e90b29..ee722d03a9573a4db5f182cf57aa10fa14f3ed47 100644
--- a/Source/bindings/scripts/code_generator_v8.py
+++ b/Source/bindings/scripts/code_generator_v8.py
@@ -75,6 +75,7 @@ from idl_types import IdlType
import v8_callback_interface
from v8_globals import includes, interfaces
import v8_interface
+import v8_private_script_interface
import v8_types
from v8_utilities import capitalize, cpp_name, conditional_string, v8_class_name
@@ -130,6 +131,12 @@ class CodeGeneratorV8(object):
header_template_filename = 'callback_interface.h'
cpp_template_filename = 'callback_interface.cpp'
generate_contents = v8_callback_interface.generate_callback_interface
+ # Currently private scripts don't have dependencies. Once private scripts have dependencies,
+ # we should add them to interface_info.
+ elif 'PrivateScriptInterface' in interface.extended_attributes:
+ header_template_filename = 'private_script_interface.h'
+ cpp_template_filename = 'private_script_interface.cpp'
+ generate_contents = v8_private_script_interface.generate_private_script_interface
else:
header_template_filename = 'interface.h'
cpp_template_filename = 'interface.cpp'
@@ -143,7 +150,8 @@ class CodeGeneratorV8(object):
# Add includes for interface itself and any dependencies
interface_info = self.interfaces_info[interface_name]
- template_contents['header_includes'].add(interface_info['include_path'])
+ if 'PrivateScriptInterface' not in interface.extended_attributes:
+ template_contents['header_includes'].add(interface_info['include_path'])
template_contents['header_includes'] = sorted(template_contents['header_includes'])
includes.update(interface_info.get('dependencies_include_paths', []))
template_contents['cpp_includes'] = sorted(includes)
« no previous file with comments | « Source/bindings/core/idl.gypi ('k') | Source/bindings/scripts/scripts.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698