Implement an infrastructure of Blink-in-JS

Source/core/core.gypi

 {
     'includes': [
       'core_generated.gypi',
     ],
     'variables': {
         # Files for which bindings (.cpp and .h files) will be generated
         'core_idl_files': [
             'animation/Animation.idl',
             'animation/AnimationEffect.idl',
             'animation/AnimationPlayer.idl',
@@ skipping 431 matching lines @@
             'xml/XMLHttpRequest.idl',
             'xml/XMLHttpRequestEventTarget.idl',
             'xml/XMLHttpRequestProgressEvent.idl',
             'xml/XMLHttpRequestUpload.idl',
             'xml/XMLSerializer.idl',
             'xml/XPathEvaluator.idl',
             'xml/XPathExpression.idl',
             'xml/XPathNSResolver.idl',
             'xml/XPathResult.idl',
             'xml/XSLTProcessor.idl',
+            '../bindings/v8/PrivateScriptTest.idl',

[Nils Barth (inactive), 2014/06/23 03:14:30]

1. Alphabetical order please (.. is at start)

2. Testing files should go in 'webcore_testing_idl_files' instead

3. 'private_source_idl_files' variable instead?

This is creating a dependency of core on bindings
(later core_bindings_v8);
I assume this is ok, but it's a bit icky-looking.
Assuming we'll have more of these, better would be a variable
like 'private_source_idl_files',
which you could include from bindings.gypi
(later: bindings_core_v8.gypi)
and then have listed at the top via: <(private_source_idl_files)

[haraken, 2014/06/23 06:01:46]

This is my question as well --- where the IDL files for PrivateScripts should be
listed.

- The IDL files for PrivateScripts (including PrivateScriptTest.idl) are not a
part of testing IDL files. They are a part of normal core/modules IDL files that
should be aggregated into aggregated binding files. Thus we cannot put them into
webcore_testing_idl_files.

- Almost all IDL files for PrivateScripts that will be added in the future will
be placed in core/ or modules/ (in order to replace the implementation of core/
and modules/ with JavaScript). PrivateScriptTest.idl will be the only IDL file
placed in bindings/.

Given the situation, where do you think I should list up the IDL files?

[Nils Barth (inactive), 2014/06/23 06:21:25]

Probably best would be a separate list, say core_private_idl_files?
Putting them in the same core list is saying that they're part of
the web interface, but these are fundamentally implementation details,
and I think we'll want to treat these pretty differently
(we're already having special cases).

Also it's weird to put 1 test file with real files;
presumably we shouldn't be *shipping* test interfaces,
which is exactly why there's separate treatment for existing
test interfaces.

Cleanest would be another category,
core_private_testing_idl_files
...but if it's only going to be one file,
and it's not going to be treated differently,
that seems a bit silly.

Safer would be to make it runtime enabled, say
[RuntimeEnabled=PrivateScript] or something

Anyway, for the test file itself:
* Ok to put in core, I think.
* Otherwise make a separate bindings_idl_files list in bindings or
bindings/core/idl.gypi and then add that to the main core list in
bindings/core/idl.gypi.

[haraken, 2014/06/23 08:15:38]

Done. I kept PrivateScriptTest.idl in bindings/v8/ and added 'binding_idl_files'
to bindings/core/v8/idl.gypi.

[Nils Barth (inactive), 2014/06/23 08:54:11]

Thanks, that's a good way to do it!

         ],
         # 'partial interface', target (right side of) 'implements', and
         # interfaces with static bindings (in bindings/v8/)
         'core_dependency_idl_files': [
             'animation/DocumentAnimation.idl',
             'animation/ElementAnimation.idl',
             'css/DocumentFontFaceSet.idl',
             'dom/ChildNode.idl',
             'dom/DocumentFullscreen.idl',
             'dom/GlobalEventHandlers.idl',
@@ skipping 2976 matching lines @@
             'loader/MixedContentCheckerTest.cpp',
             'page/NetworkStateNotifierTest.cpp',
             'rendering/RenderOverflowTest.cpp',
             'rendering/shapes/BoxShapeTest.cpp',
             'testing/UnitTestHelpers.cpp',
             'testing/UnitTestHelpers.h',
             'xml/parser/SharedBufferReaderTest.cpp',
         ],
     }
 }