Implement an infrastructure of Blink-in-JS

Source/bindings/scripts/code_generator_v8.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 54 matching lines @@
 module_pyname = os.path.splitext(module_filename)[0] + '.py'
 
 # jinja2 is in chromium's third_party directory.
 # Insert at 1 so at front to override system libraries, and
 # after path[0] == invoking script dir
 sys.path.insert(1, third_party_dir)
 import jinja2
 
 import idl_types
 from idl_types import IdlType
+import v8_private_script_interface

[Nils Barth (inactive), 2014/06/23 03:14:29]

alpha

 import v8_callback_interface
 from v8_globals import includes, interfaces
 import v8_interface
 import v8_types
 from v8_utilities import capitalize, cpp_name, conditional_string, v8_class_name
 
 
 class CodeGeneratorV8(object):
     def __init__(self, interfaces_info, cache_dir):
         interfaces_info = interfaces_info or {}
@@ skipping 38 matching lines @@
         # Set local type info
         IdlType.set_callback_functions(definitions.callback_functions.keys())
         IdlType.set_enums((enum.name, enum.values)
                           for enum in definitions.enumerations.values())
 
         # Select appropriate Jinja template and contents function
         if interface.is_callback:
             header_template_filename = 'callback_interface.h'
             cpp_template_filename = 'callback_interface.cpp'
             generate_contents = v8_callback_interface.generate_callback_interface
+        elif 'PrivateScriptInterface' in interface.extended_attributes:
+            header_template_filename = 'private_script_interface.h'
+            cpp_template_filename = 'private_script_interface.cpp'
+            generate_contents = v8_private_script_interface.generate_private_script_interface
         else:
             header_template_filename = 'interface.h'
             cpp_template_filename = 'interface.cpp'
             generate_contents = v8_interface.generate_interface
         header_template = self.jinja_env.get_template(header_template_filename)
         cpp_template = self.jinja_env.get_template(cpp_template_filename)
 
         # Generate contents (input parameters for Jinja)
         template_contents = generate_contents(interface)
         template_contents['code_generator'] = module_pyname
 
         # Add includes for interface itself and any dependencies
         interface_info = self.interfaces_info[interface_name]
-        template_contents['header_includes'].add(interface_info['include_path'])
+        if 'PrivateScriptInterface' not in interface.extended_attributes:

[Nils Barth (inactive), 2014/06/23 03:14:29]

Longer-term we can have private scripts also passed through the global
information computation, so we won't need this special case, but it's fine to
special-case at first.
Also, we'll likely *need* to do this to support dependency information,
though again, probably not necessary at first if keep it simple.
(If you plan to do this, could you add a FIXME?)

[haraken, 2014/06/23 06:01:46]

Actually I'm not sure what kind of dependency we'll need for PrivateScript
interfaces. So I'll just keep the current code as is in this CL.

[Nils Barth (inactive), 2014/06/23 06:21:25]

That's fine; just a heads-up.
Might want to add a comment, like:
# Currently private scripts don't have dependencies.

[haraken, 2014/06/23 08:15:38]

Done.

+            template_contents['header_includes'].add(interface_info['include_path'])
         template_contents['header_includes'] = sorted(template_contents['header_includes'])
         includes.update(interface_info.get('dependencies_include_paths', []))
         template_contents['cpp_includes'] = sorted(includes)
 
         # Render Jinja templates
         header_text = header_template.render(template_contents)
         cpp_text = cpp_template.render(template_contents)
         return header_text, cpp_text
 
 
@@ skipping 56 matching lines @@
 
     # Create a dummy file as output for the build system,
     # since filenames of individual cache files are unpredictable and opaque
     # (they are hashes of the template path, which varies based on environment)
     with open(dummy_filename, 'w') as dummy_file:
         pass  # |open| creates or touches the file
 
 
 if __name__ == '__main__':
     sys.exit(main(sys.argv))