Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 345833002: Handle redirects with NULL headers in PluginURLFetcher (Closed)

Created:
6 years, 6 months ago by davidben
Modified:
6 years, 6 months ago
Reviewers:
jam, mmenke
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Handle redirects with NULL headers in PluginURLFetcher This is a minimal fix for the crash. We should pass the response code from the URLRequestRedirectJob down from the browser, either by faking headers or by passing it separately along with other redirect metadata in https://crbug.com/384609. For now, treat it as 307 as all non-test URLRequestRedirectJobs are 307. BUG=382849 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
davidben
This is kinda hacky, but since it's a crash and branch point is soon, it ...
6 years, 6 months ago (2014-06-19 23:31:35 UTC) #1
mmenke
LGTM, as a temporary crash fix.
6 years, 6 months ago (2014-06-20 16:29:14 UTC) #2
jam
lgtm
6 years, 6 months ago (2014-06-20 20:06:14 UTC) #3
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 6 months ago (2014-06-20 20:07:20 UTC) #4
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 6 months ago (2014-06-20 20:07:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/345833002/1
6 years, 6 months ago (2014-06-20 20:10:09 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-21 01:00:39 UTC) #7
Message was sent while issue was closed.
Change committed as 278883

Powered by Google App Engine
This is Rietveld 408576698