Issue 34583002: Convert X11 AdvancedOptionsUtilities to generic Linux platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 34583002: Convert X11 AdvancedOptionsUtilities to generic Linux platforms (Closed)

Created:
7 years, 2 months ago by vignatti (out of this project)

Modified:
7 years, 2 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, dbeam+watch-options_chromium.org, rjkroege, dnicoara, kalyank

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Convert X11 AdvancedOptionsUtilities to generic Linux platforms The files being changed on this CL don't touch any X11 specific code, so they can used by other Linux platforms, in particular for Chrome target works under Ozone. BUG=295089 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230526

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -159 lines)			Patch
A +	chrome/browser/ui/webui/options/advanced_options_utils_linux.cc	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/browser/ui/webui/options/advanced_options_utils_x11.cc	View		1 chunk	+0 lines, -159 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

should probably be called *_linux and still only compiled on linux.

7 years, 2 months ago (2013-10-22 17:15:38 UTC) #1

vignatti (out of this project)

On 2013/10/22 17:15:38, Evan Stade wrote: > should probably be called *_linux and still only ...

7 years, 2 months ago (2013-10-23 08:32:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/34583002/50001

7 years, 2 months ago (2013-10-23 16:12:18 UTC) #5

Message was sent while issue was closed.

Change committed as 230526

Expand Messages | Collapse Messages