Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 345823003: socket_dispatcher_host.h uses webrtc, skip when webrtc is disabled (Closed)

Created:
6 years, 6 months ago by Mostyn Bramley-Moore
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

socket_dispatcher_host.h uses webrtc, skip when webrtc is disabled https://codereview.chromium.org/264793017 added some webrtc specific code to socket_dispatcher_host.h, and it only appears to be used for webrtc as far as I can see. So we should only include this file elsewhere when webrtc is enabled. BUG=363459 TEST=build with enable_webrtc=0 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279857

Patch Set 1 #

Total comments: 2

Patch Set 2 : move webrtc includes together #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Mostyn Bramley-Moore
@jiayl, mallinath2, sky: how does this look to you? (I don't have access to the ...
6 years, 6 months ago (2014-06-19 23:09:53 UTC) #1
jiayl
On 2014/06/19 23:09:53, Mostyn Bramley-Moore wrote: > @jiayl, mallinath2, sky: how does this look to ...
6 years, 6 months ago (2014-06-19 23:20:18 UTC) #2
sky
https://codereview.chromium.org/345823003/diff/1/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/345823003/diff/1/content/browser/renderer_host/render_process_host_impl.cc#newcode89 content/browser/renderer_host/render_process_host_impl.cc:89: #include "content/browser/renderer_host/p2p/socket_dispatcher_host.h" Move this with other ENABLE_WEBRTC includes below.
6 years, 6 months ago (2014-06-19 23:30:28 UTC) #3
Mallinath (Gone from Chromium)
On 2014/06/19 23:30:28, sky wrote: > https://codereview.chromium.org/345823003/diff/1/content/browser/renderer_host/render_process_host_impl.cc > File content/browser/renderer_host/render_process_host_impl.cc (right): > > https://codereview.chromium.org/345823003/diff/1/content/browser/renderer_host/render_process_host_impl.cc#newcode89 > ...
6 years, 6 months ago (2014-06-20 00:58:51 UTC) #4
Mostyn Bramley-Moore
https://codereview.chromium.org/345823003/diff/1/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/345823003/diff/1/content/browser/renderer_host/render_process_host_impl.cc#newcode89 content/browser/renderer_host/render_process_host_impl.cc:89: #include "content/browser/renderer_host/p2p/socket_dispatcher_host.h" On 2014/06/19 23:30:28, sky wrote: > Move ...
6 years, 6 months ago (2014-06-20 07:50:55 UTC) #5
Mostyn Bramley-Moore
@sky: *ping*
6 years, 6 months ago (2014-06-25 08:19:28 UTC) #6
sky
LGTM
6 years, 6 months ago (2014-06-25 16:44:58 UTC) #7
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 6 months ago (2014-06-25 16:52:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/345823003/20001
6 years, 6 months ago (2014-06-25 16:52:51 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-25 21:04:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-25 22:20:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/166102)
6 years, 6 months ago (2014-06-25 22:20:43 UTC) #12
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 6 months ago (2014-06-25 22:26:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/345823003/20001
6 years, 6 months ago (2014-06-25 22:27:01 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 23:43:19 UTC) #15
Message was sent while issue was closed.
Change committed as 279857

Powered by Google App Engine
This is Rietveld 408576698