Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: content/renderer/render_widget.cc

Issue 345823002: Move ownership of ChildFrameCompositingHelper from frame to proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_widget.h" 5 #include "content/renderer/render_widget.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/debug/trace_event.h" 10 #include "base/debug/trace_event.h"
(...skipping 25 matching lines...) Expand all
36 #include "content/renderer/external_popup_menu.h" 36 #include "content/renderer/external_popup_menu.h"
37 #include "content/renderer/gpu/compositor_output_surface.h" 37 #include "content/renderer/gpu/compositor_output_surface.h"
38 #include "content/renderer/gpu/compositor_software_output_device.h" 38 #include "content/renderer/gpu/compositor_software_output_device.h"
39 #include "content/renderer/gpu/delegated_compositor_output_surface.h" 39 #include "content/renderer/gpu/delegated_compositor_output_surface.h"
40 #include "content/renderer/gpu/mailbox_output_surface.h" 40 #include "content/renderer/gpu/mailbox_output_surface.h"
41 #include "content/renderer/gpu/render_widget_compositor.h" 41 #include "content/renderer/gpu/render_widget_compositor.h"
42 #include "content/renderer/ime_event_guard.h" 42 #include "content/renderer/ime_event_guard.h"
43 #include "content/renderer/input/input_handler_manager.h" 43 #include "content/renderer/input/input_handler_manager.h"
44 #include "content/renderer/pepper/pepper_plugin_instance_impl.h" 44 #include "content/renderer/pepper/pepper_plugin_instance_impl.h"
45 #include "content/renderer/render_frame_impl.h" 45 #include "content/renderer/render_frame_impl.h"
46 #include "content/renderer/render_frame_proxy.h"
46 #include "content/renderer/render_process.h" 47 #include "content/renderer/render_process.h"
47 #include "content/renderer/render_thread_impl.h" 48 #include "content/renderer/render_thread_impl.h"
48 #include "content/renderer/renderer_webkitplatformsupport_impl.h" 49 #include "content/renderer/renderer_webkitplatformsupport_impl.h"
49 #include "content/renderer/resizing_mode_selector.h" 50 #include "content/renderer/resizing_mode_selector.h"
50 #include "ipc/ipc_sync_message.h" 51 #include "ipc/ipc_sync_message.h"
51 #include "skia/ext/platform_canvas.h" 52 #include "skia/ext/platform_canvas.h"
52 #include "third_party/WebKit/public/platform/WebCursorInfo.h" 53 #include "third_party/WebKit/public/platform/WebCursorInfo.h"
53 #include "third_party/WebKit/public/platform/WebGraphicsContext3D.h" 54 #include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"
54 #include "third_party/WebKit/public/platform/WebRect.h" 55 #include "third_party/WebKit/public/platform/WebRect.h"
55 #include "third_party/WebKit/public/platform/WebScreenInfo.h" 56 #include "third_party/WebKit/public/platform/WebScreenInfo.h"
(...skipping 1139 matching lines...) Expand 10 before | Expand all | Expand 10 after
1195 UpdateTextInputState(NO_SHOW_IME, FROM_NON_IME); 1196 UpdateTextInputState(NO_SHOW_IME, FROM_NON_IME);
1196 UpdateSelectionBounds(); 1197 UpdateSelectionBounds();
1197 } 1198 }
1198 1199
1199 void RenderWidget::didBecomeReadyForAdditionalInput() { 1200 void RenderWidget::didBecomeReadyForAdditionalInput() {
1200 TRACE_EVENT0("renderer", "RenderWidget::didBecomeReadyForAdditionalInput"); 1201 TRACE_EVENT0("renderer", "RenderWidget::didBecomeReadyForAdditionalInput");
1201 FlushPendingInputEventAck(); 1202 FlushPendingInputEventAck();
1202 } 1203 }
1203 1204
1204 void RenderWidget::DidCommitCompositorFrame() { 1205 void RenderWidget::DidCommitCompositorFrame() {
1205 FOR_EACH_OBSERVER(RenderFrameImpl, swapped_out_frames_, 1206 FOR_EACH_OBSERVER(RenderFrameProxy, render_frame_proxies_,
1206 DidCommitCompositorFrame()); 1207 DidCommitCompositorFrame());
1207 #if defined(VIDEO_HOLE) 1208 #if defined(VIDEO_HOLE)
1208 // Not using FOR_EACH_OBSERVER because |swapped_out_frames_| and 1209 // Not using FOR_EACH_OBSERVER because |render_frame_proxies_| and
1209 // |video_hole_frames_| may have common frames. 1210 // |video_hole_frames_| may have common frames.
1210 if (!video_hole_frames_.might_have_observers()) 1211 if (!video_hole_frames_.might_have_observers())
1211 return; 1212 return;
1212 ObserverListBase<RenderFrameImpl>::Iterator iter(video_hole_frames_); 1213 ObserverListBase<RenderFrameImpl>::Iterator iter(video_hole_frames_);
1213 RenderFrameImpl* frame; 1214 RenderFrameImpl* frame;
1214 while ((frame = iter.GetNext()) != NULL) { 1215 while ((frame = iter.GetNext()) != NULL) {
1215 // Prevent duplicate notification of DidCommitCompositorFrame(). 1216 // Prevent duplicate notification of DidCommitCompositorFrame().
1216 if (!swapped_out_frames_.HasObserver(frame)) 1217 if (!render_frame_proxies_.HasObserver(frame))
1217 frame->DidCommitCompositorFrame(); 1218 frame->DidCommitCompositorFrame();
1218 } 1219 }
1219 #endif // defined(VIDEO_HOLE) 1220 #endif // defined(VIDEO_HOLE)
1220 } 1221 }
1221 1222
1222 void RenderWidget::didCommitAndDrawCompositorFrame() { 1223 void RenderWidget::didCommitAndDrawCompositorFrame() {
1223 // NOTE: Tests may break if this event is renamed or moved. See 1224 // NOTE: Tests may break if this event is renamed or moved. See
1224 // tab_capture_performancetest.cc. 1225 // tab_capture_performancetest.cc.
1225 TRACE_EVENT0("gpu", "RenderWidget::didCommitAndDrawCompositorFrame"); 1226 TRACE_EVENT0("gpu", "RenderWidget::didCommitAndDrawCompositorFrame");
1226 // Notify subclasses that we initiated the paint operation. 1227 // Notify subclasses that we initiated the paint operation.
(...skipping 817 matching lines...) Expand 10 before | Expand all | Expand 10 after
2044 new WebGraphicsContext3DCommandBufferImpl(surface_id(), 2045 new WebGraphicsContext3DCommandBufferImpl(surface_id(),
2045 GetURLForGraphicsContext3D(), 2046 GetURLForGraphicsContext3D(),
2046 gpu_channel_host.get(), 2047 gpu_channel_host.get(),
2047 attributes, 2048 attributes,
2048 lose_context_when_out_of_memory, 2049 lose_context_when_out_of_memory,
2049 limits, 2050 limits,
2050 NULL)); 2051 NULL));
2051 return context.Pass(); 2052 return context.Pass();
2052 } 2053 }
2053 2054
2054 void RenderWidget::RegisterSwappedOutChildFrame(RenderFrameImpl* frame) { 2055 void RenderWidget::RegisterRenderFrameProxy(RenderFrameProxy* proxy) {
2055 swapped_out_frames_.AddObserver(frame); 2056 render_frame_proxies_.AddObserver(proxy);
2056 } 2057 }
2057 2058
2058 void RenderWidget::UnregisterSwappedOutChildFrame(RenderFrameImpl* frame) { 2059 void RenderWidget::UnregisterRenderFrameProxy(RenderFrameProxy* proxy) {
2059 swapped_out_frames_.RemoveObserver(frame); 2060 render_frame_proxies_.RemoveObserver(proxy);
2060 } 2061 }
2061 2062
2062 void RenderWidget::RegisterRenderFrame(RenderFrameImpl* frame) { 2063 void RenderWidget::RegisterRenderFrame(RenderFrameImpl* frame) {
2063 render_frames_.AddObserver(frame); 2064 render_frames_.AddObserver(frame);
2064 } 2065 }
2065 2066
2066 void RenderWidget::UnregisterRenderFrame(RenderFrameImpl* frame) { 2067 void RenderWidget::UnregisterRenderFrame(RenderFrameImpl* frame) {
2067 render_frames_.RemoveObserver(frame); 2068 render_frames_.RemoveObserver(frame);
2068 } 2069 }
2069 2070
2070 #if defined(VIDEO_HOLE) 2071 #if defined(VIDEO_HOLE)
2071 void RenderWidget::RegisterVideoHoleFrame(RenderFrameImpl* frame) { 2072 void RenderWidget::RegisterVideoHoleFrame(RenderFrameImpl* frame) {
2072 video_hole_frames_.AddObserver(frame); 2073 video_hole_frames_.AddObserver(frame);
2073 } 2074 }
2074 2075
2075 void RenderWidget::UnregisterVideoHoleFrame(RenderFrameImpl* frame) { 2076 void RenderWidget::UnregisterVideoHoleFrame(RenderFrameImpl* frame) {
2076 video_hole_frames_.RemoveObserver(frame); 2077 video_hole_frames_.RemoveObserver(frame);
2077 } 2078 }
2078 #endif // defined(VIDEO_HOLE) 2079 #endif // defined(VIDEO_HOLE)
2079 2080
2080 } // namespace content 2081 } // namespace content
OLDNEW
« content/renderer/render_frame_impl.h ('K') | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698