Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: content/browser/frame_host/render_frame_proxy_host.cc

Issue 345823002: Move ownership of ChildFrameCompositingHelper from frame to proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_proxy_host.h" 5 #include "content/browser/frame_host/render_frame_proxy_host.h"
6 6
7 #include "content/browser/frame_host/cross_process_frame_connector.h"
7 #include "content/browser/frame_host/frame_tree_node.h" 8 #include "content/browser/frame_host/frame_tree_node.h"
8 #include "content/browser/frame_host/render_frame_host_impl.h" 9 #include "content/browser/frame_host/render_frame_host_impl.h"
10 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
11 #include "content/browser/renderer_host/render_widget_host_view_base.h"
9 #include "content/browser/site_instance_impl.h" 12 #include "content/browser/site_instance_impl.h"
10 #include "content/common/frame_messages.h" 13 #include "content/common/frame_messages.h"
11 #include "ipc/ipc_message.h" 14 #include "ipc/ipc_message.h"
12 15
13 namespace content { 16 namespace content {
14 17
15 RenderFrameProxyHost::RenderFrameProxyHost(SiteInstance* site_instance, 18 RenderFrameProxyHost::RenderFrameProxyHost(SiteInstance* site_instance,
16 FrameTreeNode* frame_tree_node) 19 FrameTreeNode* frame_tree_node)
17 : routing_id_(site_instance->GetProcess()->GetNextRoutingID()), 20 : routing_id_(site_instance->GetProcess()->GetNextRoutingID()),
18 site_instance_(site_instance), 21 site_instance_(site_instance),
19 frame_tree_node_(frame_tree_node) { 22 frame_tree_node_(frame_tree_node) {
20 GetProcess()->AddRoute(routing_id_, this); 23 GetProcess()->AddRoute(routing_id_, this);
24
25 if (!frame_tree_node_->IsMainFrame() &&
26 frame_tree_node_->parent()
27 ->render_manager()
28 ->current_frame_host()
29 ->GetSiteInstance() == site_instance) {
30 // The RenderFrameHost navigating cross-process is destroyed and a proxy for
31 // it is created in the parent's process. CrossProcessFrameConnector
32 // initialization only needs to happen on an initial cross-process
33 // navigation, when the RenderFrameHost leaves the same process as its
34 // parent. The same CrossProcessFrameConnector is used for subsequent cross-
35 // process navigations, but it will be destroyed if the frame is
36 // navigated back to the same SiteInstance as its parent.
37 cross_process_frame_connector_.reset(new CrossProcessFrameConnector(this));
38 }
21 } 39 }
22 40
23 RenderFrameProxyHost::~RenderFrameProxyHost() { 41 RenderFrameProxyHost::~RenderFrameProxyHost() {
24 if (GetProcess()->HasConnection()) 42 if (GetProcess()->HasConnection())
25 Send(new FrameMsg_DeleteProxy(routing_id_)); 43 Send(new FrameMsg_DeleteProxy(routing_id_));
26 44
27 GetProcess()->RemoveRoute(routing_id_); 45 GetProcess()->RemoveRoute(routing_id_);
28 } 46 }
29 47
48 void RenderFrameProxyHost::SetChildRWHView(RenderWidgetHostView* view) {
49 cross_process_frame_connector_->set_view(
50 static_cast<RenderWidgetHostViewChildFrame*>(view));
51 }
52
30 RenderViewHostImpl* RenderFrameProxyHost::GetRenderViewHost() { 53 RenderViewHostImpl* RenderFrameProxyHost::GetRenderViewHost() {
31 if (render_frame_host_.get()) 54 if (render_frame_host_.get())
32 return render_frame_host_->render_view_host(); 55 return render_frame_host_->render_view_host();
33 return NULL; 56 return NULL;
34 } 57 }
35 58
36 scoped_ptr<RenderFrameHostImpl> RenderFrameProxyHost::PassFrameHostOwnership() { 59 scoped_ptr<RenderFrameHostImpl> RenderFrameProxyHost::PassFrameHostOwnership() {
37 render_frame_host_->set_render_frame_proxy_host(NULL); 60 render_frame_host_->set_render_frame_proxy_host(NULL);
38 return render_frame_host_.Pass(); 61 return render_frame_host_.Pass();
39 } 62 }
40 63
41 bool RenderFrameProxyHost::Send(IPC::Message *msg) { 64 bool RenderFrameProxyHost::Send(IPC::Message *msg) {
42 // TODO(nasko): For now, RenderFrameHost uses this object to send IPC messages 65 // TODO(nasko): For now, RenderFrameHost uses this object to send IPC messages
43 // while swapped out. This can be removed once we don't have a swapped out 66 // while swapped out. This can be removed once we don't have a swapped out
44 // state on RenderFrameHosts. See https://crbug.com/357747. 67 // state on RenderFrameHosts. See https://crbug.com/357747.
45 msg->set_routing_id(routing_id_); 68 msg->set_routing_id(routing_id_);
46 return GetProcess()->Send(msg); 69 return GetProcess()->Send(msg);
47 } 70 }
48 71
49 bool RenderFrameProxyHost::OnMessageReceived(const IPC::Message& msg) { 72 bool RenderFrameProxyHost::OnMessageReceived(const IPC::Message& msg) {
73 if (cross_process_frame_connector_.get() &&
74 cross_process_frame_connector_->OnMessageReceived(msg))
75 return true;
76
50 // TODO(nasko): This can be removed once we don't have a swapped out state on 77 // TODO(nasko): This can be removed once we don't have a swapped out state on
51 // RenderFrameHosts. See https://crbug.com/357747. 78 // RenderFrameHosts. See https://crbug.com/357747.
52 if (render_frame_host_.get()) 79 if (render_frame_host_.get())
53 return render_frame_host_->OnMessageReceived(msg); 80 return render_frame_host_->OnMessageReceived(msg);
54 81
55 return false; 82 return false;
56 } 83 }
57 84
58 } // namespace content 85 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698