Move ownership of ChildFrameCompositingHelper from frame to proxy.

Move ownership of ChildFrameCompositingHelper from frame to proxy.

The ChildFrameCompositingHelper is used for swapped out RenderFrames only, which I want to eliminate and replace with RenderFrameProxy. As such, it is the RFP object that should own the helper.

BUG=357747
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278808

[nasko, 2014-06-19 21:43:26]

This is not ready yet, but it is a close enough start. Need to resolve some
android compile breaks.

[kenrb, 2014-06-20 14:28:19]

lgtm once you have it cleaned up.

https://codereview.chromium.org/345823002/diff/1/content/renderer/child_frame...
File content/renderer/child_frame_compositing_helper.cc (right):

https://codereview.chromium.org/345823002/diff/1/content/renderer/child_frame...
content/renderer/child_frame_compositing_helper.cc:190:
SkColorSetARGBInline(255, 255, 255, 0));
Was this just for testing?

https://codereview.chromium.org/345823002/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/345823002/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.h:35: struct
FrameMsg_CompositorFrameSwapped_Params;
Can these forward declarations be removed?

[nasko, 2014-06-20 17:01:34]

Ken, I made a couple of changes from the previous patch, can you take another
look?

ycheo@, boliu@, please review this for Android changes.

https://codereview.chromium.org/345823002/diff/1/content/renderer/child_frame...
File content/renderer/child_frame_compositing_helper.cc (right):

https://codereview.chromium.org/345823002/diff/1/content/renderer/child_frame...
content/renderer/child_frame_compositing_helper.cc:190:
SkColorSetARGBInline(255, 255, 255, 0));
On 2014/06/20 14:28:19, kenrb wrote:
> Was this just for testing?

Yes.

https://codereview.chromium.org/345823002/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/345823002/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.h:35: struct
FrameMsg_CompositorFrameSwapped_Params;
On 2014/06/20 14:28:19, kenrb wrote:
> Can these forward declarations be removed?

Done.

[nasko, 2014-06-20 17:03:36]

Adding xhwang@ and site-isolation-reviews@ on cc.

[boliu, 2014-06-20 17:39:03]

VIDEO_HOLE bits looks fine. And no longer need to code to check DidComposite is
not called twice on the same observer. Yay.

[nasko, 2014-06-20 17:41:20]

John, can you do an OWNERS stamp on this one?

[kenrb, 2014-06-20 18:06:13]

On 2014/06/20 17:01:34, nasko wrote:
> Ken, I made a couple of changes from the previous patch, can you take another
> look?
> 

Yup. Still lgtm.

[xhwang, 2014-06-20 18:13:00]

https://codereview.chromium.org/345823002/diff/60001/content/renderer/render_...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/345823002/diff/60001/content/renderer/render_...
content/renderer/render_widget.cc:1209: DidCommitCompositorFrame());
This looks so much cleaner. Thanks!

[jam, 2014-06-20 18:14:27]

lgtm

[nasko, 2014-06-20 18:51:18]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2014-06-20 19:04:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nasko@chromium.org/345823002/60001

[commit-bot: I haz the power, 2014-06-20 20:04:33]

Change committed as 278808