Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/browser/search_engines/template_url_unittest.cc

Issue 345803002: Move GoogleImageSearchSource() from template_url.cc to UIThreadSearchTermsData (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: No ChromeSearchTermsData, remove DCHECK, add comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_unittest.cc b/chrome/browser/search_engines/template_url_unittest.cc
index 42b55ba210c4423a0749c42854b90baa1818c89b..2ebe7a45ca7d909a0aa0969d4dad47d41e475f0b 100644
--- a/chrome/browser/search_engines/template_url_unittest.cc
+++ b/chrome/browser/search_engines/template_url_unittest.cc
@@ -34,6 +34,7 @@ class TestSearchTermsData : public SearchTermsData {
explicit TestSearchTermsData(const std::string& google_base_url);
virtual std::string GoogleBaseURLValue() const OVERRIDE;
+ virtual std::string GoogleImageSearchSource() const OVERRIDE;
private:
std::string google_base_url_;
@@ -49,6 +50,10 @@ std::string TestSearchTermsData::GoogleBaseURLValue() const {
return google_base_url_;
}
+std::string TestSearchTermsData::GoogleImageSearchSource() const {
+ return "google_image_search_source";
+}
+
// TemplateURLTest ------------------------------------------------------------
class TemplateURLTest : public testing::Test {
@@ -245,6 +250,10 @@ TEST_F(TemplateURLTest, URLRefTestImageURLWithPOST) {
base::IntToString(search_args.image_original_size.width()),
i->second);
break;
+ case TemplateURLRef::GOOGLE_IMAGE_SEARCH_SOURCE:
+ EXPECT_EQ("sbisrc", i->first);
+ EXPECT_EQ(search_terms_data.GoogleImageSearchSource(), i->second);
+ break;
case TemplateURLRef::GOOGLE_IMAGE_THUMBNAIL:
EXPECT_EQ("image_content", i->first);
EXPECT_EQ(search_args.image_thumbnail_content, i->second);

Powered by Google App Engine
This is Rietveld 408576698