Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 345773005: Show proper message when host list is empty. (Closed)

Created:
6 years, 6 months ago by Sergey Ulanov
Modified:
6 years, 6 months ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Show proper message when host list is empty. host-list-empty was placed inside of daemon-control, so it was not visible when daemon-control div was not visible. BUG=384053 http://src.chromium.org/viewvc/chrome?view=rev&revision=278739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M remoting/webapp/html/ui_me2me.html View 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sergey Ulanov
6 years, 6 months ago (2014-06-19 23:09:22 UTC) #1
kelvinp
lgtm
6 years, 6 months ago (2014-06-19 23:55:34 UTC) #2
Jamie
lgtm
6 years, 6 months ago (2014-06-20 01:03:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/345773005/1
6 years, 6 months ago (2014-06-20 01:07:15 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 11:28:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 17:14:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/30215)
6 years, 6 months ago (2014-06-20 17:14:48 UTC) #7
Sergey Ulanov
6 years, 6 months ago (2014-06-20 17:24:53 UTC) #8
Message was sent while issue was closed.
committed as r278739

Powered by Google App Engine
This is Rietveld 408576698