Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2448)

Unified Diff: apps/shell/common/shell_extensions_client.cc

Issue 345773004: Load the actual app icon in Athena. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | athena/content/DEPS » ('j') | athena/content/content_app_model_builder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/shell/common/shell_extensions_client.cc
diff --git a/apps/shell/common/shell_extensions_client.cc b/apps/shell/common/shell_extensions_client.cc
index cc2f055762b6cd7c08ecf3489361376bae8f035b..8e9bd926dd9719116d9eb684391a6ca243ada3b2 100644
--- a/apps/shell/common/shell_extensions_client.cc
+++ b/apps/shell/common/shell_extensions_client.cc
@@ -17,6 +17,7 @@
#include "extensions/common/features/permission_feature.h"
#include "extensions/common/features/simple_feature.h"
#include "extensions/common/manifest_handler.h"
+#include "extensions/common/manifest_handlers/icons_handler.h"
#include "extensions/common/permissions/permission_message_provider.h"
#include "extensions/common/permissions/permissions_info.h"
#include "extensions/common/permissions/permissions_provider.h"
@@ -105,6 +106,9 @@ void ShellExtensionsClient::Initialize() {
// initialization step specifically for API manifest handlers.
(new extensions::SocketsManifestHandler)->Register();
+ // TODO(mukai): Why not icons handler in common?
+ (new extensions::IconsHandler)->Register();
oshima 2014/06/19 23:06:22 I'll leave this to james
+
extensions::ManifestHandler::FinalizeRegistration();
// TODO(jamescook): Do we need to whitelist any extensions?
« no previous file with comments | « no previous file | athena/content/DEPS » ('j') | athena/content/content_app_model_builder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698