Translate: Hide the bubble if the user denies translating 2 times within 24 hours

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 1148 matching lines @@
 }
 
 void BrowserView::ShowTranslateBubble(content::WebContents* web_contents,
                                       translate::TranslateStep step,
                                       TranslateErrors::Type error_type) {
   if (contents_web_view_->HasFocus() &&
       !GetLocationBarView()->IsMouseHovered()) {
     content::RenderViewHost* rvh = web_contents->GetRenderViewHost();
     if (rvh->IsFocusedElementEditable())
       return;
+
+    if (IsOffTheRecord())

[sky, 2014/06/19 15:46:46]

This code is not platform specific. Can it be moved to non-platform specific
location? Perhaps browser_commands.cc:Translate?

[hajimehoshi, 2014/06/20 11:38:45]

Done. Moved to ChromeTranslateClient.

BrowserCommands is now used only when clicking the translate icon. Clicking icon
calls ShowTranslateBubble directly for now. The other triggers (the context menu
and automatic translation) uses ChromeTranslateClient. It seems better to unify
these ways to use ChromeTranslateClient.

+      return;
+
+    PrefService* pref = browser_->profile()->GetOriginalProfile()->GetPrefs();
+    scoped_ptr<TranslatePrefs> translate_prefs =
+        ChromeTranslateClient::CreateTranslatePrefs(pref);
+    if (translate_prefs->IsBubbleHidden())
+      return;
   }
 
   ChromeTranslateClient* chrome_translate_client =
       ChromeTranslateClient::FromWebContents(web_contents);
   LanguageState& language_state = chrome_translate_client->GetLanguageState();
   language_state.SetTranslateEnabled(true);
 
   TranslateBubbleView::ShowBubble(
       GetToolbarView()->GetTranslateBubbleAnchor(), web_contents, step,
       error_type);
@@ skipping 1367 matching lines @@
       !GetLocationBar()->GetOmniboxView()->model()->popup_model()->IsOpen()) {
     gfx::Point icon_bottom(
         toolbar_->location_bar()->GetLocationBarAnchorPoint());
     ConvertPointToTarget(toolbar_->location_bar(), this, &icon_bottom);
     gfx::Point infobar_top(0, infobar_container_->GetVerticalOverlap(NULL));
     ConvertPointToTarget(infobar_container_, this, &infobar_top);
     top_arrow_height = infobar_top.y() - icon_bottom.y();
   }
   return top_arrow_height;
 }