Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345733006: UMA Metrics to track profile deletion, along with signed-in status. (Closed)

Created:
6 years, 6 months ago by Mike Lerman
Modified:
6 years, 6 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

UMA Metrics to track profile deletion, along with signed-in status. BUG=357693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278606

Patch Set 1 #

Total comments: 2

Patch Set 2 : Enum for the histogram config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/browser/profiles/profile_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_metrics.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_metrics.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mike Lerman
Most wonderful reviewers, I request a review of my humble CL. Thanks!
6 years, 6 months ago (2014-06-19 17:40:58 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/345733006/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/345733006/diff/20001/tools/metrics/histograms/histograms.xml#newcode22442 tools/metrics/histograms/histograms.xml:22442: +<histogram name="Profile.Delete" units="Boolean"> Add a BooleanSignedIn enum, so the ...
6 years, 6 months ago (2014-06-19 19:20:13 UTC) #2
Mike Lerman
https://codereview.chromium.org/345733006/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/345733006/diff/20001/tools/metrics/histograms/histograms.xml#newcode22442 tools/metrics/histograms/histograms.xml:22442: +<histogram name="Profile.Delete" units="Boolean"> On 2014/06/19 19:20:13, Alexei Svitkine wrote: ...
6 years, 6 months ago (2014-06-19 19:31:19 UTC) #3
Alexei Svitkine (slow)
lgtm
6 years, 6 months ago (2014-06-19 19:52:19 UTC) #4
noms (inactive)
profiles lgtm
6 years, 6 months ago (2014-06-19 19:56:59 UTC) #5
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 6 months ago (2014-06-19 19:57:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/345733006/40001
6 years, 6 months ago (2014-06-19 20:01:18 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 00:55:17 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 05:12:34 UTC) #9
Message was sent while issue was closed. 
Change committed as 278606

Powered by Google App Engine
This is Rietveld 408576698