Re-enable PPAPI browser tests on mac.

Re-enable PPAPI browser tests on mac.

R=ccameron@chromium.org, piman, raymes@chromium.org

[piman, 2014-06-19 20:33:28]

lgtm

[danakj, 2014-06-19 21:37:28]

Looks like the pass on Mac now, but not on windows

  Actual: "FramePPAPIForceAsync FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(48):
!(context.is_null()), FramePPAPI FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(48):
!(context.is_null()), FramePPAPIBlocking FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(48):
!(context.is_null()), FramePPAPIBackground FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(48):
!(context.is_null()), FrameGLForceAsync FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(76):
!(context.is_null()), FrameGL FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(76):
!(context.is_null()), FrameGLBlocking FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(76):
!(context.is_null()), FrameGLBackground FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(76):
!(context.is_null()), ExtensionsGLForceAsync FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(104):
!(context.is_null()), ExtensionsGL FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(104):
!(context.is_null()), ExtensionsGLBlocking FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(104):
!(context.is_null()), ExtensionsGLBackground FAIL: Failure in
e:\\\\b\\\\build\\\\slave\\\\win\\\\build\\\\src\\\\ppapi\\\\tests\\\\test_graphics_3d.cc(104):
!(context.is_null())"

[raymes, 2014-06-20 00:12:53]

lgtm with a comment which may not be relevant if we have to disable them again
on win:

https://codereview.chromium.org/345733005/diff/1/chrome/test/ppapi/ppapi_brow...
File chrome/test/ppapi/ppapi_browsertest.cc (right):

https://codereview.chromium.org/345733005/diff/1/chrome/test/ppapi/ppapi_brow...
chrome/test/ppapi/ppapi_browsertest.cc:247:
TEST_PPAPI_NACL(MAYBE_NACL_Graphics3D)
Looks like MAYBE_NACL_Graphics3D is always defined as Graphics3D? I think we can
remove the #defines

The same with MAYBE_OUT_Graphics3D.

[danakj, 2014-06-23 15:59:34]

Updated patch to just re-enable mac.

[danakj, 2014-06-23 15:59:45]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-23 16:00:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/345733005/20001

[Peng, 2014-06-23 16:06:22]

On 2014/06/23 16:00:48, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/danakj@chromium.org/345733005/20001

FYI, The Graphics3D can not be created sucessfully in some mac dbg buildbots. :(

http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg...

[danakj, 2014-06-23 16:46:14]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-07-17 17:45:53]

Sounds like we're not ready for this then, though it passed all trybots. So I'll
close and someone can look into it.

[raymes, 2014-07-18 00:12:17]

Thanks Dana. All the try jobs look green - what ended up blocking this?

[danakj, 2014-07-18 15:18:18]

Peng's comment.
On Jul 17, 2014 8:12 PM, <raymes@chromium.org> wrote:

> Thanks Dana. All the try jobs look green - what ended up blocking this?
>
> https://codereview.chromium.org/345733005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.