Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 34573002: Convert views X11 UnhandledKeyboardEventHandler to other Linux platforms (Closed)

Created:
7 years, 2 months ago by vignatti (out of this project)
Modified:
7 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, rjkroege, dnicoara, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Convert views X11 UnhandledKeyboardEventHandler to other Linux platforms We have two Linux platforms supported under Aura: Ozone and X11. The files being changed on this CL don't touch any X11 specific code, so they can used by Ozone as well. Linux GTK+ takes another path, not using views, so this change doesn't affect that. BUG=295089 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230803

Patch Set 1 #

Patch Set 2 : use _linux.cc instead _aura.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
D ui/views/controls/webview/unhandled_keyboard_event_handler_aurax11.cc View 1 chunk +0 lines, -30 lines 0 comments Download
A + ui/views/controls/webview/unhandled_keyboard_event_handler_linux.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/views/controls/webview/webview.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
vignatti (out of this project)
7 years, 2 months ago (2013-10-23 13:56:02 UTC) #1
sky
How was this being handled on win-aura before? By that I mean presumably we didn't ...
7 years, 2 months ago (2013-10-23 14:49:55 UTC) #2
vignatti (out of this project)
On 2013/10/23 14:49:55, sky wrote: > How was this being handled on win-aura before? By ...
7 years, 2 months ago (2013-10-23 15:19:24 UTC) #3
sky
Yes.
7 years, 2 months ago (2013-10-23 20:08:32 UTC) #4
vignatti (out of this project)
On 2013/10/23 20:08:32, sky wrote: > Yes. alright, thanks. PTAL.
7 years, 2 months ago (2013-10-24 08:08:23 UTC) #5
sky
LGTM
7 years, 2 months ago (2013-10-24 15:42:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/34573002/70001
7 years, 2 months ago (2013-10-24 16:13:05 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-24 20:43:30 UTC) #8
Message was sent while issue was closed.
Change committed as 230803

Powered by Google App Engine
This is Rietveld 408576698