Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345723003: [DevTools] Separate text autosizing from device metrics override. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Separate text autosizing from device metrics override. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177104

Patch Set 1 #

Patch Set 2 : New approach #

Patch Set 3 : Removed dead code #

Total comments: 2

Patch Set 4 : rebase #

Patch Set 5 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -98 lines) Patch
M LayoutTests/inspector/text-autosizing-override.html View 1 2 chunks +6 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 4 15 chunks +39 lines, -31 lines 0 comments Download
M Source/devtools/front_end/elements/OverridesView.js View 1 2 3 2 chunks +2 lines, -8 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 2 3 9 chunks +0 lines, -47 lines 0 comments Download
M Source/devtools/front_end/ui/SettingsUI.js View 2 chunks +3 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
dgozman
Take a look please.
6 years, 6 months ago (2014-06-20 12:21:22 UTC) #1
dgozman
PTAL
6 years, 6 months ago (2014-06-23 10:17:50 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/345723003/diff/40001/Source/core/inspector/InspectorPageAgent.cpp File Source/core/inspector/InspectorPageAgent.cpp (right): https://codereview.chromium.org/345723003/diff/40001/Source/core/inspector/InspectorPageAgent.cpp#newcode124 Source/core/inspector/InspectorPageAgent.cpp:124: // chrome/browser/chrome_content_browser_client.cc, GetFontScaleMultiplier(...) There is no such file.
6 years, 6 months ago (2014-06-23 13:23:56 UTC) #3
dgozman
https://codereview.chromium.org/345723003/diff/40001/Source/core/inspector/InspectorPageAgent.cpp File Source/core/inspector/InspectorPageAgent.cpp (right): https://codereview.chromium.org/345723003/diff/40001/Source/core/inspector/InspectorPageAgent.cpp#newcode124 Source/core/inspector/InspectorPageAgent.cpp:124: // chrome/browser/chrome_content_browser_client.cc, GetFontScaleMultiplier(...) On 2014/06/23 13:23:56, pfeldman wrote: > ...
6 years, 5 months ago (2014-06-27 11:40:03 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-06-27 11:40:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/345723003/60001
6 years, 5 months ago (2014-06-27 11:41:19 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-06-27 12:48:17 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 12:53:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/13119)
6 years, 5 months ago (2014-06-27 12:53:50 UTC) #9
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-06-27 13:17:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/345723003/80001
6 years, 5 months ago (2014-06-27 13:18:57 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 14:27:35 UTC) #12
Message was sent while issue was closed. 
Change committed as 177104

Powered by Google App Engine
This is Rietveld 408576698