Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 345723002: Add functions to support NV_path_rendering in OpenGL ES (Closed)

Created:
6 years, 6 months ago by Kimmo Kinnunen
Modified:
6 years, 5 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@desktop-es
Visibility:
Public.

Description

Add functions to support NV_path_rendering in OpenGL ES Add OpenGL ES extension functions needed to support NV_path_rendering in OpenGL ES. The added glProgramPathFragmentInputGenNV call is defined in NV_path_rendering revision 30, similar to following: Append to the end of the "Shader Inputs" subsection of Section 3.12.2 "Shader Execution": The command void ProgramPathFragmentInputGenNV(uint program, int location, enum genMode, int components, const float *coeffs); controls how a user-defined (non-built-in) fragment input of a GLSL program object is computed for fragment shading operations that occur as a result of CoverFillPathNV or CoverStrokePathNV. /program/ names a GLSL program object. If /program/ has not been successfully linked, the error INVALID_OPERATION is generated. The given fragment input generation state is loaded into the fragment input variable location identified by /location/. This location is a value returned either by GetProgramResourceLocation with a /programInterface/ of FRAGMENT_INPUT_NV and a given fragment shader input variable name or by GetProgramResourceiv with FRAGMENT_INPUT_NV for the /programInterface/ and LOCATION for the property for a given fragment input resource index. .... glProgramPathFragmentInputGenNV will be used instead of glPathTexGen, because the latter depends on fixed function pipeline that is not exposed in ES. Also add glGetProgramResourceLocation from OpenGL 4.3 or ARB_program_interface_query. Also add FRAGMENT_INPUT define to be used with glGetProgramResourceLocation. The added functions are not used yet, but they're needed when implementing NV_path_rendering support for OpenGL ES. They can also be used on OpenGL. Remove uncalled NV_path_rendering functions, so they do not cause confusion or take space in the interface definition. The ones that are later used can be re-added when needed. Remove definitions NV_path_rendering that are for NV_path_rendering function parameters that are not used. The ones that are later used can be re-added when needed. Committed: https://skia.googlesource.com/skia/+/4a995dfff2ecf91e8bf999d77e3218cec596232c Committed: https://skia.googlesource.com/skia/+/32b9a3b02ed6b8bab4a25b6cb8853f5bea4b87ba

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : program_interface_query is part of ES 3.1, not available anywhere else #

Patch Set 4 : rebase #

Patch Set 5 : #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Total comments: 2

Patch Set 8 : add the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -264 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 2 chunks +5 lines, -25 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +2 lines, -33 lines 0 comments Download
M src/gpu/gl/GrGLAssembleGLESInterface.h View 1 2 3 4 5 6 1 chunk +29 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +5 lines, -33 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 4 5 6 7 1 chunk +21 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 4 chunks +4 lines, -77 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 2 3 4 5 6 3 chunks +44 lines, -94 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Kimmo Kinnunen
PTAL? Depends on the 'es on desktop' patch.
6 years, 6 months ago (2014-06-19 07:08:19 UTC) #1
bsalomon
lgtm, will land after the other patch lands.
6 years, 6 months ago (2014-06-19 13:10:37 UTC) #2
Kimmo Kinnunen
The CQ bit was checked by kkinnunen@nvidia.com
6 years, 6 months ago (2014-06-23 06:15:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/345723002/60001
6 years, 6 months ago (2014-06-23 06:16:52 UTC) #4
commit-bot: I haz the power
Change committed as 4a995dfff2ecf91e8bf999d77e3218cec596232c
6 years, 6 months ago (2014-06-23 06:32:36 UTC) #5
rmistry
A revert of this CL has been created in https://codereview.chromium.org/349983002/ by rmistry@google.com. The reason for ...
6 years, 6 months ago (2014-06-23 13:06:07 UTC) #6
Kimmo Kinnunen
Had to change this slightly after LGTM. Defining sensible EXT_direct_state_access for ES seems to take ...
6 years, 5 months ago (2014-07-02 11:14:20 UTC) #7
bsalomon
lgtm https://codereview.chromium.org/345723002/diff/120001/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/345723002/diff/120001/src/gpu/gl/GrGLCaps.cpp#newcode324 src/gpu/gl/GrGLCaps.cpp:324: NULL != gli->fFunctions.fProgramPathFragmentInputGen)); Can you explain in a ...
6 years, 5 months ago (2014-07-02 13:25:33 UTC) #8
Kimmo Kinnunen
Thanks for the review. https://codereview.chromium.org/345723002/diff/120001/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/345723002/diff/120001/src/gpu/gl/GrGLCaps.cpp#newcode324 src/gpu/gl/GrGLCaps.cpp:324: NULL != gli->fFunctions.fProgramPathFragmentInputGen)); On 2014/07/02 ...
6 years, 5 months ago (2014-07-03 05:43:20 UTC) #9
Kimmo Kinnunen
The CQ bit was checked by kkinnunen@nvidia.com
6 years, 5 months ago (2014-07-03 05:43:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/345723002/140001
6 years, 5 months ago (2014-07-03 05:44:19 UTC) #11
commit-bot: I haz the power
Change committed as 32b9a3b02ed6b8bab4a25b6cb8853f5bea4b87ba
6 years, 5 months ago (2014-07-03 05:56:44 UTC) #12
Kimmo Kinnunen
For some reason, caused Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE to fail. http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/builds/2604/steps/RunTests/logs/stdio Can't repro on NV HW. I'm in ...
6 years, 5 months ago (2014-07-03 11:39:23 UTC) #13
Kimmo Kinnunen
6 years, 5 months ago (2014-07-03 11:59:11 UTC) #14
Message was sent while issue was closed.
Mike, this broke the Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE .. It probably
takes me a while to get the HW, so in the mean time, if the bot/test is known to
be stable, the commit could be reverted..

Powered by Google App Engine
This is Rietveld 408576698