Issue 345713005: Make sure MediaStreamManager handles requests in order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345713005: Make sure MediaStreamManager handles requests in order. (Closed)

Created:
6 years, 6 months ago by perkj_chrome

Modified:
6 years, 6 months ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make sure MediaStreamManager handles requests in order. This cl changes MediaStreamManager to internally use a list of requests instead of a map. The purpose is to make sure requests are serviced in the order they are requested rather than be dependent on the map key. This is to avoid that the requests are serviced out of order if several requests are waiting for a media device to be opened. BUG=381893 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278453

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -18 lines)			Patch
M	content/browser/media/webrtc_getusermedia_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc	View		2 chunks	+10 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/media/media_stream_manager.h	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/media/media_stream_manager.cc	View	1	2 chunks	+18 lines, -8 lines	0 comments	Download