Issue 345663002: Check if the parserthread has been shut down before returning it to the ThreadedDataProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345663002: Check if the parserthread has been shut down before returning it to the ThreadedDataProvider (Closed)

Created:
6 years, 6 months ago by oystein (OOO til 10th of July)

Modified:
6 years, 6 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

The WebThreadedDataReceiver will now check if the parserthread is still alive before returning it to the ThreadedDataProvider This fixes a crash when a renderer is shut down while a request is still alive, due to the ResourceDispatcher being shut down after Blink is. R=abarth BUG=386383 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176487

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	Source/core/html/parser/HTMLDocumentParser.cpp	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oysteine@chromium.org/345663002/1

6 years, 6 months ago (2014-06-19 02:54:42 UTC) #3

Message was sent while issue was closed.

Change committed as 176487

Expand Messages | Collapse Messages