Source/core/rendering/compositing/GraphicsLayerUpdater.cpp - Issue 345653002: Issue paint invalidations before and after changing offsetFromRenderer and reconfiguring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

Issue 345653002: Issue paint invalidations before and after changing offsetFromRenderer and reconfiguring (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased two tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/compositing/GraphicsLayerUpdater.h ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

diff --git a/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp b/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

index 0c7daf3e11dec91f3dd50023db669fca18c25da5..ab9428cef19276e0aea05f6ae3f3c0567bc39e7f 100644

--- a/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

+++ b/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

@@ -62,7 +62,7 @@ GraphicsLayerUpdater::~GraphicsLayerUpdater()

{

}

-void GraphicsLayerUpdater::update(RenderLayer& layer, UpdateType updateType, const UpdateContext& context)

+void GraphicsLayerUpdater::update(Vector<RenderLayer*>& layersNeedingPaintInvalidation, RenderLayer& layer, UpdateType updateType, const UpdateContext& context)

{

if (layer.hasCompositedLayerMapping()) {

CompositedLayerMappingPtr mapping = layer.compositedLayerMapping();

@@ -84,7 +84,7 @@ void GraphicsLayerUpdater::update(RenderLayer& layer, UpdateType updateType, con

if (mapping->updateGraphicsLayerConfiguration(updateType))

m_needsRebuildTree = true;

- mapping->updateGraphicsLayerGeometry(updateType, compositingContainer);

+ mapping->updateGraphicsLayerGeometry(updateType, compositingContainer, layersNeedingPaintInvalidation);

updateType = mapping->updateTypeForChildren(updateType);

mapping->clearNeedsGraphicsLayerUpdate();

@@ -98,7 +98,7 @@ void GraphicsLayerUpdater::update(RenderLayer& layer, UpdateType updateType, con

UpdateContext childContext(context, layer);

for (RenderLayer* child = layer.firstChild(); child; child = child->nextSibling())

- update(*child, updateType, childContext);

+ update(layersNeedingPaintInvalidation, *child, updateType, childContext);

}

#if ASSERT_ENABLED