Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Unified Diff: Source/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 345613004: Correct the squashing origin w.r.t. the transformed ancestor to take into account rounding to integ… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/compositing/squashing/squash-transform-repainting-transformed-child-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/compositing/CompositedLayerMapping.cpp
diff --git a/Source/core/rendering/compositing/CompositedLayerMapping.cpp b/Source/core/rendering/compositing/CompositedLayerMapping.cpp
index d81a0afa9ac3ba1656b6ecabf7928dd5cbf350ac..383f83a18db464921fdd2105fa80f820b37336b3 100644
--- a/Source/core/rendering/compositing/CompositedLayerMapping.cpp
+++ b/Source/core/rendering/compositing/CompositedLayerMapping.cpp
@@ -551,9 +551,6 @@ void CompositedLayerMapping::updateSquashingLayerGeometry(const LayoutPoint& off
totalSquashBounds.unite(squashedBounds);
}
- *offsetFromTransformedAncestor = referenceOffsetFromTransformedAncestor;
- offsetFromTransformedAncestor->moveBy(totalSquashBounds.location());
-
// The totalSquashBounds is positioned with respect to referenceLayer of this CompositedLayerMapping.
// But the squashingLayer needs to be positioned with respect to the ancestor CompositedLayerMapping.
// The conversion between referenceLayer and the ancestor CLM is already computed as
@@ -566,6 +563,9 @@ void CompositedLayerMapping::updateSquashingLayerGeometry(const LayoutPoint& off
squashingLayer->setPosition(squashLayerBounds.location());
squashingLayer->setSize(squashLayerBounds.size());
+ *offsetFromTransformedAncestor = referenceOffsetFromTransformedAncestor;
+ offsetFromTransformedAncestor->move(squashLayerOriginInOwningLayerSpace);
+
// Now that the squashing bounds are known, we can convert the RenderLayer painting offsets
// from CLM owning layer space to the squashing layer space.
//
« no previous file with comments | « LayoutTests/compositing/squashing/squash-transform-repainting-transformed-child-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698