content/browser/service_worker/service_worker_register_job.h - Issue 345583002: ServiceWorker: Add a function to abort all pending jobs in SWJobCoordinator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.h

Issue 345583002: ServiceWorker: Add a function to abort all pending jobs in SWJobCoordinator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments and add test cases Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_job_unittest.cc ('K') | « content/browser/service_worker/service_worker_job_unittest.cc ('k') | content/browser/service_worker/service_worker_register_job.cc » ('j') | content/browser/service_worker/service_worker_register_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.h

diff --git a/content/browser/service_worker/service_worker_register_job.h b/content/browser/service_worker/service_worker_register_job.h

index 2d668ede249bd566d778f463d147ada7899db5a7..db10fa611185c4136e98ac9494751b3a0a6fe158 100644

--- a/content/browser/service_worker/service_worker_register_job.h

+++ b/content/browser/service_worker/service_worker_register_job.h

@@ -53,6 +53,7 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase {

// ServiceWorkerRegisterJobBase implementation:

virtual void Start() OVERRIDE;

+ virtual void Abort() OVERRIDE;

virtual bool Equals(ServiceWorkerRegisterJobBase* job) OVERRIDE;

virtual RegistrationJobType GetType() OVERRIDE;

@@ -70,7 +71,8 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase {

INSTALL,

STORE,

ACTIVATE,

- COMPLETE

+ COMPLETE,

+ ABORT,

};

// Holds internal state of ServiceWorkerRegistrationJob, to compel use of the

@@ -103,6 +105,7 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase {

void ActivateAndContinue();

void OnActivateFinished(ServiceWorkerStatusCode status);

void Complete(ServiceWorkerStatusCode status);

+ void CompleteInternal(ServiceWorkerStatusCode status);

void ResolvePromise(ServiceWorkerStatusCode status,

ServiceWorkerRegistration* registration,