Issue 345563009: Renumber HandshakeFailureReason enums so that there are no big gaps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345563009: Renumber HandshakeFailureReason enums so that there are no big gaps. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)

Modified:
6 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Renumber HandshakeFailureReason enums so that there are no big gaps. Changed quic_crypto_client_config.cc to just left shift the reject reason before uploading the reject reasons to UMA. Thanks rch for the suggestion. Deleted RejectReasonToPackedError and the unit tests for that method. Minor cleanup of code. Merge internal change: 69963869 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -86 lines)			Patch
M	net/quic/crypto/crypto_handshake.h	View	1 chunk	+34 lines, -13 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config.cc	View	2 chunks	+5 lines, -38 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config_test.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages