Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345563008: Rename "managed (mode|user)" to "supervised user" (part 4) (Closed)

Created:
6 years, 6 months ago by Marc Treib
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Bernhard Bauer
Project:
chromium
Visibility:
Public.

Description

Rename "managed (mode|user)" to "supervised user" (part 4) Followup to https://codereview.chromium.org/335273005/, https://codereview.chromium.org/335833003/, and https://codereview.chromium.org/316863002/ This CL renames the remaining C++ stuff, except for CrOS-specific code. Still missing: - ChromeOS-specific code in c/b/chromeos/login/managed/ and ash/system/ - JavaScript - Resource names - The global ENABLE_MANAGED_USERS define TBR=msw@chromium.org (c/b/ui) TBR=noms@chromium.org (c/b/profiles) TBR=atwilson@chromium.org (components/signin) TBR=finnur@chromium.org (c/b/extensions, c/common/extensions, and extensions/common) All the TBRs are just renames. BUG=385113 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279414

Patch Set 1 #

Patch Set 2 : comments #

Total comments: 3

Patch Set 3 : review comment #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -215 lines) Patch
M chrome/browser/extensions/installed_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_startup_installer_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/avatar_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/api/managed_mode_private/managed_mode_handler.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/common/extensions/api/managed_mode_private/managed_mode_handler.cc View 1 chunk +0 lines, -99 lines 0 comments Download
A + chrome/common/extensions/api/supervised_user_private/supervised_user_handler.h View 1 2 chunks +15 lines, -14 lines 0 comments Download
A + chrome/common/extensions/api/supervised_user_private/supervised_user_handler.cc View 4 chunks +20 lines, -20 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/url_constants.h View 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M components/signin/core/browser/profile_oauth2_token_service.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/permission_message.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Marc Treib
6 years, 6 months ago (2014-06-24 09:54:52 UTC) #1
Bernhard Bauer
LGTM https://codereview.chromium.org/345563008/diff/20001/chrome/common/extensions/chrome_manifest_handlers.cc File chrome/common/extensions/chrome_manifest_handlers.cc (right): https://codereview.chromium.org/345563008/diff/20001/chrome/common/extensions/chrome_manifest_handlers.cc#newcode61 chrome/common/extensions/chrome_manifest_handlers.cc:61: (new SupervisedUserHandler)->Register(); Move down please, so the handlers ...
6 years, 6 months ago (2014-06-24 09:58:59 UTC) #2
Marc Treib
https://codereview.chromium.org/345563008/diff/20001/chrome/common/extensions/chrome_manifest_handlers.cc File chrome/common/extensions/chrome_manifest_handlers.cc (right): https://codereview.chromium.org/345563008/diff/20001/chrome/common/extensions/chrome_manifest_handlers.cc#newcode61 chrome/common/extensions/chrome_manifest_handlers.cc:61: (new SupervisedUserHandler)->Register(); On 2014/06/24 09:58:59, Bernhard Bauer wrote: > ...
6 years, 6 months ago (2014-06-24 10:03:08 UTC) #3
Bernhard Bauer
https://codereview.chromium.org/345563008/diff/20001/chrome/common/extensions/chrome_manifest_handlers.cc File chrome/common/extensions/chrome_manifest_handlers.cc (right): https://codereview.chromium.org/345563008/diff/20001/chrome/common/extensions/chrome_manifest_handlers.cc#newcode61 chrome/common/extensions/chrome_manifest_handlers.cc:61: (new SupervisedUserHandler)->Register(); On 2014/06/24 10:03:08, treib wrote: > On ...
6 years, 6 months ago (2014-06-24 10:15:37 UTC) #4
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-24 12:31:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/345563008/60001
6 years, 6 months ago (2014-06-24 12:32:09 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 15:52:17 UTC) #7
Message was sent while issue was closed. 
Change committed as 279414

Powered by Google App Engine
This is Rietveld 408576698