Add Uint32 representation

runtime/vm/intermediate_language.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
 #define VM_INTERMEDIATE_LANGUAGE_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
@@ skipping 563 matching lines @@
   void SetReachingType(CompileType* type) {
     reaching_type_ = type;
   }
 
   void PrintTo(BufferFormatter* f) const;
 
   const char* DebugName() const { return "Value"; }
 
   bool IsSmiValue() { return Type()->ToCid() == kSmiCid; }
 
+  // Returns true if this value binds to a 32-bit mint instruction.
+  bool BindsTo32BitMint() const;
+
+  // Returns true if this value binds to the constant: 0xFFFFFFFF.
+  bool BindsTo32BitMaskConstant() const;
+
   // Return true if the value represents a constant.
   bool BindsToConstant() const;
 
   // Return true if the value represents the constant null.
   bool BindsToConstantNull() const;
 
   // Assert if BindsToConstant() is false, otherwise returns the constant value.
   const Object& BoundConstant() const;
 
   // Compile time constants, Bool, Smi and Nulls do not need to update
@@ skipping 138 matching lines @@
   M(MathUnary)                                                                 \
   M(MathMinMax)                                                                \
   M(UnboxDouble)                                                               \
   M(BoxDouble)                                                                 \
   M(BoxFloat32x4)                                                              \
   M(UnboxFloat32x4)                                                            \
   M(BoxInt32x4)                                                                \
   M(UnboxInt32x4)                                                              \
   M(UnboxInteger)                                                              \
   M(BoxInteger)                                                                \
+  M(MintConverter)                                                             \
   M(BinaryMintOp)                                                              \
   M(ShiftMintOp)                                                               \
   M(UnaryMintOp)                                                               \
   M(CheckArrayBound)                                                           \
   M(Constraint)                                                                \
   M(StringToCharCode)                                                          \
   M(StringFromCharCode)                                                        \
   M(StringInterpolate)                                                         \
   M(InvokeMathCFunction)                                                       \
   M(MergedMath)                                                                \
@@ skipping 2038 matching lines @@
 
   // Inclusive.
   bool Overlaps(int64_t min_int, int64_t max_int) const;
 
   bool IsUnsatisfiable() const;
 
   bool IsFinite() const {
     return !min_.IsInfinity() && !max_.IsInfinity();
   }
 
+  bool Is32BitMask() const {
+    return min_.IsConstant() && (min_.ConstantValue() == 0) &&
+           max_.IsConstant() && (max_.ConstantValue() == kMaxUint32);
+  }
+
+  void Make32BitMask() {
+    min_ = RangeBoundary::FromConstant(0);
+    // TODO(johnmccutchan): If the range has a smaller max we should use it.
+    max_ = RangeBoundary::FromConstant(kMaxUint32);
+  }
+
   // Clamp this to be within size.
   void Clamp(RangeBoundary::RangeSize size);
 
   static void Add(const Range* left_range,
                   const Range* right_range,
                   RangeBoundary* min,
                   RangeBoundary* max,
                   Definition* left_defn);
 
   static void Sub(const Range* left_range,
@@ skipping 2459 matching lines @@
 
   Definition* Canonicalize(FlowGraph* flow_graph);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(UnboxInt32x4Instr);
 };
 
 
 class UnboxIntegerInstr : public TemplateDefinition<1> {
  public:
-  UnboxIntegerInstr(Value* value, intptr_t deopt_id) {
+  UnboxIntegerInstr(Value* value, intptr_t deopt_id)
+      : is_32_bit_(false) {
     SetInputAt(0, value);
     deopt_id_ = deopt_id;
   }
 
+  virtual void PrintTo(BufferFormatter* f) const;
+
   Value* value() const { return inputs_[0]; }
 
   virtual bool CanDeoptimize() const {
     return (value()->Type()->ToCid() != kSmiCid)
         && (value()->Type()->ToCid() != kMintCid);
   }
 
   virtual Representation representation() const {
-    return kUnboxedMint;
+    return is_32_bit() ? kUnboxedMint32 : kUnboxedMint;
   }
 
+  bool is_32_bit() const { return is_32_bit_; }
+  void set_is_32_bit(bool v) { is_32_bit_ = v; }
 
   virtual void InferRange();
 
   DECLARE_INSTRUCTION(UnboxInteger)
   virtual CompileType ComputeType() const;
 
   virtual bool AllowsCSE() const { return true; }
   virtual EffectSet Effects() const { return EffectSet::None(); }
   virtual EffectSet Dependencies() const { return EffectSet::None(); }
   virtual bool AttributesEqual(Instruction* other) const { return true; }
 
   virtual bool MayThrow() const { return false; }
 
  private:
+  bool is_32_bit_;
   DISALLOW_COPY_AND_ASSIGN(UnboxIntegerInstr);
 };
 
 
 class MathUnaryInstr : public TemplateDefinition<1> {
  public:
   enum MathUnaryKind {
     kIllegal,
     kSin,
     kCos,
@@ skipping 1718 matching lines @@
 
   virtual bool MayThrow() const { return false; }
 
  private:
   const Token::Kind op_kind_;
 
   DISALLOW_COPY_AND_ASSIGN(BinaryFloat64x2OpInstr);
 };
 
 
+class MintConverterInstr : public TemplateDefinition<1> {
+ public:
+  enum Conversion {
+    kMint32ToMint,
+    kMintToMint32,
+  };
+
+  MintConverterInstr(Conversion conversion_kind, Value* val)
+      : conversion_kind_(conversion_kind) {
+    ASSERT((conversion_kind_ == kMint32ToMint) ||
+           (conversion_kind_ == kMintToMint32));
+    SetInputAt(0, val);
+  }
+
+  Value* value() const { return inputs_[0]; }
+
+  intptr_t conversion_kind() const { return conversion_kind_; }
+
+  virtual bool CanDeoptimize() const { return false; }
+
+  virtual Representation representation() const {
+    return (conversion_kind_ == kMint32ToMint) ? kUnboxedMint : kUnboxedMint32;
+  }
+
+  virtual Representation RequiredInputRepresentation(intptr_t idx) const {
+    ASSERT(idx == 0);
+    return (conversion_kind_ == kMint32ToMint) ? kUnboxedMint32 : kUnboxedMint;
+  }
+
+  virtual EffectSet Effects() const { return EffectSet::None(); }
+  virtual EffectSet Dependencies() const { return EffectSet::None(); }
+  virtual bool AttributesEqual(Instruction* other) const {
+    ASSERT(other->IsMintConverter());
+    return conversion_kind() == other->AsMintConverter()->conversion_kind();
+  }
+
+  virtual bool MayThrow() const { return false; }
+
+  DECLARE_INSTRUCTION(MintConverter)
+
+ private:
+  intptr_t conversion_kind_;
+  DISALLOW_COPY_AND_ASSIGN(MintConverterInstr);
+};
+
+
 class BinaryMintOpInstr : public TemplateDefinition<2> {
  public:
   BinaryMintOpInstr(Token::Kind op_kind,
                            Value* left,
                            Value* right,
                            intptr_t deopt_id)
-      : op_kind_(op_kind) {
+      : op_kind_(op_kind),
+        is_32_bit_(false) {
     SetInputAt(0, left);
     SetInputAt(1, right);
     // Override generated deopt-id.
     deopt_id_ = deopt_id;
   }
 
   Value* left() const { return inputs_[0]; }
   Value* right() const { return inputs_[1]; }
 
   Token::Kind op_kind() const { return op_kind_; }
 
+  bool IsInput32Bit(intptr_t i) const {
+    return RequiredInputRepresentation(i) == kUnboxedMint32;
+  }
+
+  bool is_32_bit() const { return is_32_bit_; }
+  void set_is_32_bit(bool v) { is_32_bit_ = v; }
+
   virtual void PrintOperandsTo(BufferFormatter* f) const;
+  virtual void PrintTo(BufferFormatter* f) const;
 
   virtual bool CanDeoptimize() const {
     return FLAG_throw_on_javascript_int_overflow ||
-        (op_kind() == Token::kADD) || (op_kind() == Token::kSUB);
+        (!is_32_bit() &&
+            ((op_kind() == Token::kADD) || (op_kind() == Token::kSUB)));
   }
 
   virtual Representation representation() const {
-    return kUnboxedMint;
+    return is_32_bit() ? kUnboxedMint32 : kUnboxedMint;
   }
 
-  virtual Representation RequiredInputRepresentation(intptr_t idx) const {
-    ASSERT((idx == 0) || (idx == 1));
-    return kUnboxedMint;
-  }
+  virtual Representation RequiredInputRepresentation(intptr_t idx) const;
 
   virtual intptr_t DeoptimizationTarget() const {
     // Direct access since this instruction cannot deoptimize, and the deopt-id
     // was inherited from another instruction that could deoptimize.
     return deopt_id_;
   }
 
   virtual void InferRange();
 
   virtual Definition* Canonicalize(FlowGraph* flow_graph);
 
   DECLARE_INSTRUCTION(BinaryMintOp)
   virtual CompileType ComputeType() const;
 
   virtual bool AllowsCSE() const { return true; }
   virtual EffectSet Effects() const { return EffectSet::None(); }
   virtual EffectSet Dependencies() const { return EffectSet::None(); }
   virtual bool AttributesEqual(Instruction* other) const {
     ASSERT(other->IsBinaryMintOp());
     return op_kind() == other->AsBinaryMintOp()->op_kind();
   }
 
   virtual bool MayThrow() const { return false; }
 
  private:
   const Token::Kind op_kind_;
+  bool is_32_bit_;
 
   DISALLOW_COPY_AND_ASSIGN(BinaryMintOpInstr);
 };
 
 
 class ShiftMintOpInstr : public TemplateDefinition<2> {
  public:
   ShiftMintOpInstr(Token::Kind op_kind,
                    Value* left,
                    Value* right,
                    intptr_t deopt_id)
-      : op_kind_(op_kind) {
+      : op_kind_(op_kind),
+        is_32_bit_(false) {
     ASSERT(op_kind == Token::kSHR || op_kind == Token::kSHL);
     SetInputAt(0, left);
     SetInputAt(1, right);
     // Override generated deopt-id.
     deopt_id_ = deopt_id;
   }
 
   Value* left() const { return inputs_[0]; }
   Value* right() const { return inputs_[1]; }
 
   Token::Kind op_kind() const { return op_kind_; }
 
+  bool IsInput32Bit(intptr_t i) const {
+    return RequiredInputRepresentation(i) == kUnboxedMint32;
+  }
+
+  bool is_32_bit() const { return is_32_bit_; }
+  void set_is_32_bit(bool v) { is_32_bit_ = v; }
+
   virtual void PrintOperandsTo(BufferFormatter* f) const;
+  virtual void PrintTo(BufferFormatter* f) const;
 
-  virtual bool CanDeoptimize() const { return true; }
+  virtual bool CanDeoptimize() const {
+    return true;
+  }
 
   virtual CompileType ComputeType() const;
 
   virtual Representation representation() const {
-    return kUnboxedMint;
+    return is_32_bit() ? kUnboxedMint32 : kUnboxedMint;
+  }
+
+  bool CanShiftLeftOverflow() const {
+    return !IsInput32Bit(0) && !is_32_bit();
   }
 
   virtual Representation RequiredInputRepresentation(intptr_t idx) const {
     ASSERT((idx == 0) || (idx == 1));
-    return (idx == 0) ? kUnboxedMint : kTagged;
+    if (idx == 1) {
+      return kTagged;
+    }
+    return InputAt(idx)->BindsTo32BitMint() ? kUnboxedMint32 : kUnboxedMint;
   }
 
   virtual intptr_t DeoptimizationTarget() const {
     // Direct access since this instruction cannot deoptimize, and the deopt-id
     // was inherited from another instruction that could deoptimize.
     return deopt_id_;
   }
 
   virtual void InferRange();
 
   DECLARE_INSTRUCTION(ShiftMintOp)
 
   virtual bool AllowsCSE() const { return true; }
   virtual EffectSet Effects() const { return EffectSet::None(); }
   virtual EffectSet Dependencies() const { return EffectSet::None(); }
   virtual bool AttributesEqual(Instruction* other) const {
     return op_kind() == other->AsShiftMintOp()->op_kind();
   }
 
   virtual bool MayThrow() const { return false; }
 
  private:
   const Token::Kind op_kind_;
+  bool is_32_bit_;
 
   DISALLOW_COPY_AND_ASSIGN(ShiftMintOpInstr);
 };
 
 
 class UnaryMintOpInstr : public TemplateDefinition<1> {
  public:
   UnaryMintOpInstr(Token::Kind op_kind, Value* value, intptr_t deopt_id)
-      : op_kind_(op_kind) {
+      : op_kind_(op_kind),
+        is_32_bit_(false) {
     ASSERT(op_kind == Token::kBIT_NOT);
     SetInputAt(0, value);
     // Override generated deopt-id.
     deopt_id_ = deopt_id;
   }
 
   Value* value() const { return inputs_[0]; }
 
   Token::Kind op_kind() const { return op_kind_; }
 
+  bool IsInput32Bit(intptr_t i) const {
+    return RequiredInputRepresentation(i) == kUnboxedMint32;
+  }
+
+  bool is_32_bit() const { return is_32_bit_; }
+  void set_is_32_bit(bool v) { is_32_bit_ = v; }
+
   virtual void PrintOperandsTo(BufferFormatter* f) const;
+  virtual void PrintTo(BufferFormatter* f) const;
 
   virtual bool CanDeoptimize() const {
-    return FLAG_throw_on_javascript_int_overflow;
+    return FLAG_throw_on_javascript_int_overflow && !is_32_bit();
   }
 
   virtual Representation representation() const {
-    return kUnboxedMint;
+    return is_32_bit() ? kUnboxedMint32 : kUnboxedMint;
   }
 
   virtual Representation RequiredInputRepresentation(intptr_t idx) const {
     ASSERT(idx == 0);
-    return kUnboxedMint;
+    return InputAt(idx)->BindsTo32BitMint() ? kUnboxedMint32 : kUnboxedMint;
   }
 
   virtual intptr_t DeoptimizationTarget() const {
     // Direct access since this instruction cannot deoptimize, and the deopt-id
     // was inherited from another instruction that could deoptimize.
     return deopt_id_;
   }
 
   DECLARE_INSTRUCTION(UnaryMintOp)
   virtual CompileType ComputeType() const;
 
   virtual bool AllowsCSE() const { return true; }
   virtual EffectSet Effects() const { return EffectSet::None(); }
   virtual EffectSet Dependencies() const { return EffectSet::None(); }
   virtual bool AttributesEqual(Instruction* other) const {
     return op_kind() == other->AsUnaryMintOp()->op_kind();
   }
 
   virtual bool MayThrow() const { return false; }
 
  private:
   const Token::Kind op_kind_;
+  bool is_32_bit_;
 
   DISALLOW_COPY_AND_ASSIGN(UnaryMintOpInstr);
 };
 
 
 class BinarySmiOpInstr : public TemplateDefinition<2> {
  public:
   BinarySmiOpInstr(Token::Kind op_kind,
                    Value* left,
                    Value* right,
@@ skipping 25 matching lines @@
   DECLARE_INSTRUCTION(BinarySmiOp)
   virtual CompileType ComputeType() const;
 
   virtual bool CanDeoptimize() const;
 
   virtual bool AllowsCSE() const { return true; }
   virtual EffectSet Effects() const { return EffectSet::None(); }
   virtual EffectSet Dependencies() const { return EffectSet::None(); }
   virtual bool AttributesEqual(Instruction* other) const;
 
-  void PrintTo(BufferFormatter* f) const;
+  virtual void PrintTo(BufferFormatter* f) const;
 
   virtual void InferRange();
 
   virtual Definition* Canonicalize(FlowGraph* flow_graph);
 
   // Returns true if right is a non-zero Smi constant which absolute value is
   // a power of two.
   bool RightIsPowerOfTwoConstant() const;
 
   virtual bool MayThrow() const { return false; }
@@ skipping 928 matching lines @@
   ForwardInstructionIterator* current_iterator_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_INTERMEDIATE_LANGUAGE_H_