Fix issues that broke editing on browsers without Shadow DOM support.

dart/site/try/src/interaction_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library trydart.interaction_manager;
 
 import 'dart:html';
 
 import 'dart:convert' show
     JSON;
@@ skipping 210 matching lines @@
       : super.internal() {
     state = new InitialState(this);
     heartbeat = new Timer.periodic(HEARTBEAT_INTERVAL, onHeartbeat);
   }
 
   void onInput(Event event) => state.onInput(event);
 
   void onKeyUp(KeyboardEvent event) => state.onKeyUp(event);
 
   void onMutation(List<MutationRecord> mutations, MutationObserver observer) {
+    workAroundFirefoxBug();
     try {
       try {
         return state.onMutation(mutations, observer);
       } finally {
         // Discard any mutations during the observer, as these can lead to
         // infinite loop.
         observer.takeRecords();
       }
     } catch (error, stackTrace) {
       try {
@@ skipping 57 matching lines @@
   InteractionContext get context;
 
   // TODO(ahe): Remove this.
   Set<AnchorElement> get oldDiagnostics {
     throw 'Use context.oldDiagnostics instead';
   }
 
   void set state(InteractionState newState);
 
   void onStateChanged(InteractionState previous) {
-    print('State change ${previous.runtimeType} -> ${runtimeType}.');
   }
 
   void transitionToInitialState() {
     state = new InitialState(context);
   }
 }
 
 class InitialState extends InteractionState {
   final InteractionContext context;
   bool requestCodeCompletion = false;
 
   InitialState(this.context);
 
   void set state(InteractionState state) {
     InteractionState previous = context.state;
     if (previous != state) {
       context.state = state;
       state.onStateChanged(previous);
     }
   }
 
   void onInput(Event event) {
     state = new PendingInputState(context);
   }
 
   void onKeyUp(KeyboardEvent event) {
     if (computeHasModifier(event)) {
-      print('onKeyUp (modified)');
       onModifiedKeyUp(event);
     } else {
-      print('onKeyUp (unmodified)');
       onUnmodifiedKeyUp(event);
     }
   }
 
   void onModifiedKeyUp(KeyboardEvent event) {
   }
 
   void onUnmodifiedKeyUp(KeyboardEvent event) {
     switch (event.keyCode) {
       case KeyCode.ENTER: {
@@ skipping 26 matching lines @@
 
     // This is a hack to get Safari (iOS) to send mutation events on
     // contenteditable.
     // TODO(ahe): Move to onInput?
     var newDiv = new DivElement();
     hackDiv.replaceWith(newDiv);
     hackDiv = newDiv;
   }
 
   void onMutation(List<MutationRecord> mutations, MutationObserver observer) {
-    print('onMutation');
-
     removeCodeCompletion();
 
     Selection selection = window.getSelection();
     TrySelection trySelection = new TrySelection(mainEditorPane, selection);
 
     Set<Node> normalizedNodes = new Set<Node>();
     for (MutationRecord record in mutations) {
       normalizeMutationRecord(record, trySelection, normalizedNodes);
     }
 
@@ skipping 21 matching lines @@
         for (String line in splitLines(currentText)) {
           List<Node> lineNodes = <Node>[];
           state = tokenizeAndHighlight(
               line, state, offset, trySelection, lineNodes);
           offset += line.length;
           nodes.add(makeLine(lineNodes, state));
         }
 
         node.parent.insertAllBefore(nodes, node);
         node.remove();
-        trySelection.adjust(selection);
+        if (mainEditorPane.contains(trySelection.anchorNode)) {

[ahe, 2014/06/27 11:23:28]

This sometimes happens on Firefox. It is related to when you delete the last
character in a line, but it isn't deterministic.

[Johnni Winther, 2014/07/02 08:40:54]

Put this in a comment.

[ahe, 2014/07/04 13:52:00]

Done.

+          trySelection.adjust(selection);
+        }
 
         // TODO(ahe): We know almost exactly what has changed.  It could be
         // more efficient to only communicate what changed.
         context.currentCompilationUnit.content = getText(mainEditorPane);
 
         // Discard highlighting mutations.
         observer.takeRecords();
         return;
       }
     }
@@ skipping 703 matching lines @@
     Text newNode = new Text('$buffer');
     node.replaceWith(newNode);
     if (selectionOffset != -1) {
       selection.anchorNode = newNode;
       selection.anchorOffset = selectionOffset;
     }
   }
   if (!record.removedNodes.isEmpty) {
     normalizedNodes.add(findLine(record.target));
   }
-  if (record.type == "characterData") {
+  if (record.type == "characterData" && record.target.parent != null) {

[ahe, 2014/06/27 11:23:28]

Firefox sends two records when the last character of a text node was deleted.

1. Stating that the text node was removed from its parent element (the text node
is in record.removedNodes, and record.target is the parent).

2. A "characterData" record with the empty text node as target.

[Johnni Winther, 2014/07/02 08:40:54]

Put this in a comment.

[ahe, 2014/07/04 13:52:00]

Done.

     normalizedNodes.add(findLine(record.target));
   }
 }
 
 // Finds the line of [node] (a parent node with CSS class 'lineNumber').
 // If no such parent exists, return mainEditorPane if it is a parent.
 // Otherwise return [node].
 Node findLine(Node node) {
   for (Node n = node; n != null; n = n.parent) {
     if (n is Element && n.classes.contains('lineNumber')) return n;
@@ skipping 32 matching lines @@
 bool isCompilerStageMarker(String message) {
   return
       message.startsWith('Package root is ') ||
       message.startsWith('Compiling ') ||
       message == "Resolving..." ||
       message.startsWith('Resolved ') ||
       message == "Inferring types..." ||
       message == "Compiling..." ||
       message.startsWith('Compiled ');
 }
+
+void workAroundFirefoxBug() {
+  Selection selection = window.getSelection();
+  if (!isCollapsed(selection)) return;
+  Node node = selection.anchorNode;
+  int offset = selection.anchorOffset;
+  if (selection.anchorNode is Element && selection.anchorOffset != 0) {

[ahe, 2014/06/27 11:23:28]

In some cases, Firefox reports the wrong anchorOffset (always seems to be 6)
when anchorNode is an Element. I've discovered that moving the cursor back and
forth fixes that.

[Johnni Winther, 2014/07/02 08:40:54]

Again, put this in a comment.

[ahe, 2014/07/04 13:52:00]

Done.

+    selection
+        ..modify('move', 'backward', 'character')
+        ..modify('move', 'forward', 'character');
+    print('Worked around Firefox selection bug $node@$offset -> '
+          '${selection.anchorNode}@${selection.anchorOffset}.');
+  }
+}