Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 345553006: Files.app: Remove the "Got it" button from the hard unplugged nortification. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
mtomasz, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Files.app: Remove the "Got it" button from the hard unplugged nortification. BUG=389434 TEST=test on a real device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/background/js/device_handler.js View 4 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
@kinaba, @mtomasz - PTAL the CL? Thank you!
6 years, 5 months ago (2014-06-27 06:12:33 UTC) #1
mtomasz
lgtm
6 years, 5 months ago (2014-06-27 06:14:15 UTC) #2
kinaba
lgtm
6 years, 5 months ago (2014-06-27 06:20:09 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-06-27 06:22:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/345553006/1
6 years, 5 months ago (2014-06-27 06:23:25 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 08:52:32 UTC) #6
Message was sent while issue was closed.
Change committed as 280280

Powered by Google App Engine
This is Rietveld 408576698