Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/class_view.html

Issue 345543003: Send allocation stats with each class and show in class view. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/vmservice/client/lib/src/service/object.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/lib/src/elements/class_view.html
===================================================================
--- runtime/bin/vmservice/client/lib/src/elements/class_view.html (revision 37499)
+++ runtime/bin/vmservice/client/lib/src/elements/class_view.html (working copy)
@@ -86,12 +86,6 @@
<div class="memberValue">{{ cls.vmName }}</div>
</div>
</template>
- <div class="memberItem">
- <div class="memberName">retained size<br>(all instances)</div>
- <div class="memberValue">
- <eval-link callback="{{ retainedSize }}"></eval-link>
- </div>
- </div>
</div>
</div>
@@ -138,6 +132,22 @@
</div>
</curly-block><br><br>
</template>
+
+ <template if="{{ !cls.hasNoAllocations }}">
+ current instances ({{ cls.newSpace.current.instances + cls.oldSpace.current.instances }})
+ <div class="memberItem">
+ <div class="memberName">shallow size</div>
+ <div class="memberValue">
+ {{ cls.newSpace.current.bytes + cls.oldSpace.current.bytes }}
+ </div>
+ </div>
+ <div class="memberItem">
+ <div class="memberName">retained size</div>
+ <div class="memberValue">
+ <eval-link callback="{{ retainedSize }}"></eval-link>
+ </div>
+ </div>
+ </template>
</div>
<hr>
« no previous file with comments | « no previous file | runtime/bin/vmservice/client/lib/src/service/object.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698