runtime/bin/vmservice/client/lib/src/service/object.dart - Issue 345543003: Send allocation stats with each class and show in class view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/service/object.dart

Issue 345543003: Send allocation stats with each class and show in class view. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/vmservice/client/lib/src/elements/class_view.html ('K') | « runtime/bin/vmservice/client/lib/src/elements/class_view.html ('k') | runtime/vm/class_table.h » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/service/object.dart

===================================================================

--- runtime/bin/vmservice/client/lib/src/service/object.dart (revision 37499)

+++ runtime/bin/vmservice/client/lib/src/service/object.dart (working copy)

@@ -1044,8 +1044,8 @@

@observable ServiceMap error;

- final Allocations newSpace = new Allocations();

- final Allocations oldSpace = new Allocations();

+ @reflectable final Allocations newSpace = new Allocations();

Cutch 2014/06/20 18:10:49 @reflectable should no longer be needed with polym

koda 2014/06/20 18:37:04 Done.

+ @reflectable final Allocations oldSpace = new Allocations();

bool get hasNoAllocations => newSpace.empty && oldSpace.empty;

@@ -1109,6 +1109,12 @@

superClass._addToChildren(this);

}

error = map['error'];

+ var allocation_stats = map['allocation_stats'];

Cutch 2014/06/20 18:10:49 New service fields should use dartCamelCase.

koda 2014/06/20 18:37:04 Done.

+ if (allocation_stats != null) {

+ newSpace.update(allocation_stats['new']);

+ oldSpace.update(allocation_stats['old']);

+ }

}

void _addToChildren(Class cls) {