Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345533005: Parse extra parameters on x-chrome-manage-accounts header (Closed)

Created:
6 years, 6 months ago by guohui
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Parse extra parameters on x-chrome-manage-accounts header BUG=375416 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278599

Patch Set 1 : #

Total comments: 5

Patch Set 2 : nits fixed #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -65 lines) Patch
M chrome/browser/extensions/api/principals_private/principals_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_global_error.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_header_helper.h View 1 2 3 chunks +18 lines, -8 lines 0 comments Download
M chrome/browser/signin/signin_header_helper.cc View 1 2 7 chunks +58 lines, -28 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/avatar_label.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.h View 1 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
guohui
Hey, could you please review the CL? sky@ for chrome/browser/ui/... rogerta@ for general review. Thanks, ...
6 years, 6 months ago (2014-06-18 20:49:55 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm with comments below. https://codereview.chromium.org/345533005/diff/20002/chrome/browser/signin/signin_header_helper.h File chrome/browser/signin/signin_header_helper.h (right): https://codereview.chromium.org/345533005/diff/20002/chrome/browser/signin/signin_header_helper.h#newcode86 chrome/browser/signin/signin_header_helper.h:86: ProfileIOData* io_data); Does this method ...
6 years, 6 months ago (2014-06-19 14:47:21 UTC) #2
sky
LGTM https://codereview.chromium.org/345533005/diff/20002/chrome/browser/ui/views/profiles/profile_chooser_view.h File chrome/browser/ui/views/profiles/profile_chooser_view.h (right): https://codereview.chromium.org/345533005/diff/20002/chrome/browser/ui/views/profiles/profile_chooser_view.h#newcode61 chrome/browser/ui/views/profiles/profile_chooser_view.h:61: Browser* browser); On 2014/06/19 14:47:21, Roger Tawa wrote: ...
6 years, 6 months ago (2014-06-19 16:03:06 UTC) #3
guohui
https://codereview.chromium.org/345533005/diff/20002/chrome/browser/signin/signin_header_helper.h File chrome/browser/signin/signin_header_helper.h (right): https://codereview.chromium.org/345533005/diff/20002/chrome/browser/signin/signin_header_helper.h#newcode86 chrome/browser/signin/signin_header_helper.h:86: ProfileIOData* io_data); On 2014/06/19 14:47:21, Roger Tawa wrote: > ...
6 years, 6 months ago (2014-06-19 17:44:19 UTC) #4
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 6 months ago (2014-06-19 17:44:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/345533005/50001
6 years, 6 months ago (2014-06-19 17:46:56 UTC) #6
guohui
The CQ bit was unchecked by guohui@chromium.org
6 years, 6 months ago (2014-06-19 19:05:49 UTC) #7
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 6 months ago (2014-06-19 20:20:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/345533005/90001
6 years, 6 months ago (2014-06-19 20:22:49 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 04:51:58 UTC) #10
Message was sent while issue was closed. 
Change committed as 278599

Powered by Google App Engine
This is Rietveld 408576698