Fix stack capture on overflow for Error.stackTraceLimit == Infinity

Fix stack capture on overflow for Error.stackTraceLimit == Infinity

Bug found by Andrew Paprocki <andrew@ishiboo.com>;.

R=mstarzinger@chromium.org, yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21902

[Yang, 2014-06-18 12:07:39]

https://codereview.chromium.org/345533002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/345533002/diff/1/src/isolate.cc#newcode796
src/isolate.cc:796: int limit;
Can we simply use FastD2IChecked here? Also, please note that in V8 we generally
use brackets around if-else blocks.

[wingo, 2014-06-18 12:26:43]

On 2014/06/18 12:07:39, Yang wrote:
> https://codereview.chromium.org/345533002/diff/1/src/isolate.cc
> File src/isolate.cc (right):
> 
> https://codereview.chromium.org/345533002/diff/1/src/isolate.cc#newcode796
> src/isolate.cc:796: int limit;
> Can we simply use FastD2IChecked here? Also, please note that in V8 we
generally
> use brackets around if-else blocks.

Sure, although it's not clear to me what FastD2IChecked does with a NaN.  Will
figure that out and fix the style.

[Yang, 2014-06-18 12:27:47]

On 2014/06/18 12:26:43, wingo wrote:
> On 2014/06/18 12:07:39, Yang wrote:
> > https://codereview.chromium.org/345533002/diff/1/src/isolate.cc
> > File src/isolate.cc (right):
> > 
> > https://codereview.chromium.org/345533002/diff/1/src/isolate.cc#newcode796
> > src/isolate.cc:796: int limit;
> > Can we simply use FastD2IChecked here? Also, please note that in V8 we
> generally
> > use brackets around if-else blocks.
> 
> Sure, although it's not clear to me what FastD2IChecked does with a NaN.  Will
> figure that out and fix the style.

It should convert a NaN to MIN_INT, since every comparison with a NaN fails.

[wingo, 2014-06-18 12:42:46]

Fixed nits, and updated FastD2IChecked comment.

[Yang, 2014-06-18 12:45:58]

On 2014/06/18 12:42:46, wingo wrote:
> Fixed nits, and updated FastD2IChecked comment.

lgtm.

[Michael Starzinger, 2014-06-18 13:50:06]

LGTM.

[wingo, 2014-06-20 14:28:03]

Committed patchset #2 manually as r21902 (presubmit successful).