An object should only be promoted to the old generation if it survived a scavenge operation.

An object should only be promoted to the old generation if it survived a scavenge operation.

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21915

[Michael Starzinger, 2014-06-18 10:46:39]

LGTM if benchmarks support it.

https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc#newcode1978
src/mark-compact.cc:1978: int
MarkCompactCollector::DiscoverAndPromoteBlackObjectsOnPage(
nit: IMHO the name of this function no longer applies, should be maybe rename it
to "DiscoverAndMigrateBlackObjectsOnPage"?

https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc#newcode2013
src/mark-compact.cc:2013: if (heap_->ShouldBePromoted(object->address(), size)
&&
nit: s/heap_/heap()/

[Hannes Payer (out of office), 2014-06-18 11:40:30]

https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc#newcode1978
src/mark-compact.cc:1978: int
MarkCompactCollector::DiscoverAndPromoteBlackObjectsOnPage(
On 2014/06/18 10:46:39, Michael Starzinger wrote:
> nit: IMHO the name of this function no longer applies, should be maybe rename
it
> to "DiscoverAndMigrateBlackObjectsOnPage"?

I renamed it to DiscoverAndEvacuateBlackObjectsOnPage.

https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc#newcode2013
src/mark-compact.cc:2013: if (heap_->ShouldBePromoted(object->address(), size)
&&
On 2014/06/18 10:46:39, Michael Starzinger wrote:
> nit: s/heap_/heap()/

Done.

[Hannes Payer (out of office), 2014-06-23 08:51:06]

Committed patchset #3 manually as r21915 (presubmit successful).