Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 345523002: An object should only be promoted to the old generation if it survived a scavenge operation. (Closed)

Created:
6 years, 6 months ago by Hannes Payer (out of office)
Modified:
6 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

An object should only be promoted to the old generation if it survived a scavenge operation. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21915

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/heap-inl.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/mark-compact.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mark-compact.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 6 months ago (2014-06-18 09:18:16 UTC) #1
Michael Starzinger
LGTM if benchmarks support it. https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc#newcode1978 src/mark-compact.cc:1978: int MarkCompactCollector::DiscoverAndPromoteBlackObjectsOnPage( nit: IMHO ...
6 years, 6 months ago (2014-06-18 10:46:39 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc#newcode1978 src/mark-compact.cc:1978: int MarkCompactCollector::DiscoverAndPromoteBlackObjectsOnPage( On 2014/06/18 10:46:39, Michael Starzinger wrote: > ...
6 years, 6 months ago (2014-06-18 11:40:30 UTC) #3
Hannes Payer (out of office)
6 years, 6 months ago (2014-06-23 08:51:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r21915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698