Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: tools/parser-shell.cc

Issue 345513003: Revert "Parser: Delay internalizing strings and values." (r21841) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gyp/v8.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/parser-shell.cc
diff --git a/tools/parser-shell.cc b/tools/parser-shell.cc
index f14c0008b42b1fa5794803f534b9acd4c920d8db..c2291857f0ccb30f836a8cf1fa40cae000b5e4dd 100644
--- a/tools/parser-shell.cc
+++ b/tools/parser-shell.cc
@@ -44,18 +44,6 @@
using namespace v8::internal;
-class StringResource8 : public v8::String::ExternalAsciiStringResource {
- public:
- StringResource8(const char* data, int length)
- : data_(data), length_(length) { }
- virtual size_t length() const { return length_; }
- virtual const char* data() const { return data_; }
-
- private:
- const char* data_;
- int length_;
-};
-
std::pair<TimeDelta, TimeDelta> RunBaselineParser(
const char* fname, Encoding encoding, int repeat, v8::Isolate* isolate,
v8::Handle<v8::Context> context) {
@@ -75,9 +63,7 @@ std::pair<TimeDelta, TimeDelta> RunBaselineParser(
break;
}
case LATIN1: {
- StringResource8* string_resource =
- new StringResource8(reinterpret_cast<const char*>(source), length);
- source_handle = v8::String::NewExternal(isolate, string_resource);
+ source_handle = v8::String::NewFromOneByte(isolate, source);
break;
}
}
« no previous file with comments | « tools/gyp/v8.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698