Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: test/cctest/test-parsing.cc

Issue 345513003: Revert "Parser: Delay internalizing strings and values." (r21841) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-ast.cc ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 79b32e8000658b017723b2fc3260195189955419..550ac17a060eccc728c6f92cc5c151475e55b4bc 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -31,7 +31,6 @@
#include "src/v8.h"
-#include "src/ast-value-factory.h"
#include "src/compiler.h"
#include "src/execution.h"
#include "src/isolate.h"
@@ -797,10 +796,8 @@ void TestScanRegExp(const char* re_source, const char* expected) {
CHECK(start == i::Token::DIV || start == i::Token::ASSIGN_DIV);
CHECK(scanner.ScanRegExpPattern(start == i::Token::ASSIGN_DIV));
scanner.Next(); // Current token is now the regexp literal.
- i::AstValueFactory ast_value_factory(NULL);
- ast_value_factory.Internalize(CcTest::i_isolate());
i::Handle<i::String> val =
- scanner.CurrentSymbol(&ast_value_factory)->string();
+ scanner.AllocateInternalizedString(CcTest::i_isolate());
i::DisallowHeapAllocation no_alloc;
i::String::FlatContent content = val->GetFlatContent();
CHECK(content.IsAscii());
@@ -2552,20 +2549,3 @@ TEST(FuncNameInferrerEscaped) {
i::DeleteArray(two_byte_source);
i::DeleteArray(two_byte_name);
}
-
-
-TEST(RegressionLazyFunctionWithErrorWithArg) {
- // The bug occurred when a lazy function had an error which requires a
- // parameter (such as "unknown label" here). The error message was processed
- // before the AstValueFactory containing the error message string was
- // internalized.
- v8::Isolate* isolate = CcTest::isolate();
- v8::HandleScope scope(isolate);
- LocalContext env;
- i::FLAG_lazy = true;
- i::FLAG_min_preparse_length = 0;
- CompileRun("function this_is_lazy() {\n"
- " break p;\n"
- "}\n"
- "this_is_lazy();\n");
-}
« no previous file with comments | « test/cctest/test-ast.cc ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698