Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: src/variables.cc

Issue 345513003: Revert "Parser: Delay internalizing strings and values." (r21841) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/variables.h ('k') | test/cctest/test-ast.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/variables.cc
diff --git a/src/variables.cc b/src/variables.cc
index 3fc18fcfc913343053c36a35ab530368eefac5cd..906b6ab7d58cad2d8b7cffe351c4eb41c8d8f655 100644
--- a/src/variables.cc
+++ b/src/variables.cc
@@ -33,7 +33,7 @@ const char* Variable::Mode2String(VariableMode mode) {
Variable::Variable(Scope* scope,
- const AstString* name,
+ Handle<String> name,
VariableMode mode,
bool is_valid_ref,
Kind kind,
@@ -52,6 +52,8 @@ Variable::Variable(Scope* scope,
is_used_(false),
initialization_flag_(initialization_flag),
interface_(interface) {
+ // Names must be canonicalized for fast equality checks.
+ ASSERT(name->IsInternalizedString());
// Var declared variables never need initialization.
ASSERT(!(mode == VAR && initialization_flag == kNeedsInitialization));
}
« no previous file with comments | « src/variables.h ('k') | test/cctest/test-ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698